as a longterm maintainer, writing proper docs is quite tricky and I know ours are far away form perfect. if you can come up with enhancement/suggestions, that would be amazing

https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.github/CONTRIBUTING.md.erb that's our contributing.md

I can imagine how hard it is, and my intention is not to complain

yeah, I was there

a section about how to use it with the dev containers would be nice

(or almost) https://github.com/voxpupuli/puppet-elasticsearch/blob/master/.github/CONTRIBUTING.md#dependencies

for sure you can expect a PR for that ;)

binford2k: is the puppet-dev-tools container still supported?

now I'm struggling with my PR for elasticsearch

many thanks for the pointer!

your welcome!

bastelfreak: we are actually talking about that this week. We have several images that are very similar and we may coalesce them into one.

bastelfreak: but it or an equivalent will be maintained

nice

I think CD4PE uses it?

or suggests using it. something like tat

yes it does. And the biggest reason they have their own instead of using the stock pdk image is that it includes onceover

ha!

so

any plans to pic kup onceover? :)

tentatively yes

neat

So now my PRs are on its way for elasticsearch I've re-read https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.github/CONTRIBUTING.md.erb , there is a "new" (for me it's new) "Unit tests in docker" section... that ironically doesn't worl for elasticsearch repo:

#0 5.641 You have requested:

#0 5.641   puppet ~> 6.0

#0 5.641

#0 5.641 The bundle currently has puppet locked at 7.23.0.

#0 5.641 Try running

bundle update puppet

I guess Dockerfile should also do bundle update

I'll admit I haven't used the Dockerfile ever