Puppet Community

because your pdk output says `puppet-lint: legacy fact`

ah dang it this teaches me to take information second hand

which would then be this issue <https://github.com/mmckinst/puppet-lint-legacy_facts-check/issues/38>

to be fair both plugins are quite similar :smile:

we're in contact with the maintainer and I hope that both plugins will be migrated to us

that will make it easier for us to publish releases. But I don't expect that we will come up with a bugfix for that issue soonish

ok what we were thinking in that case was to update the PDK to use a default template that disabled that check for next realease. Does that sound ok? We can track it and re-enable when its fixed

we had no issues with that in our vox pupuli modules (as far as I can remember). I think we introduced the topscope check first and then the legacy fact check. maybe that made a difference

some of our customers have held back on PDK versions for quite a while so suddenly shock themselves when they get round to upgrading them :sadpanda:

any chance you can take a look at the check code and maybe come up with a fix?

if we did would we be able to get it added in ok?

he's working for apple and merging open source stuff isn't allowed by Apple basically?! that's why we are working on a migration to vox pupuli. Then we could merge it

I feel his pain my past jobs were horrendous for open source contributions

I was wanting to get Javier from openlogic into some customers to help on that education front

"ask for forgiveness, not permission" is usually a good idea, but apple also likes to sue people, so...

it’s probably mostly that, since Apple does a lot of open source work. similar at my company, it was annoying to get approvals to make contributions, so many employees don’t bother and figure out bad workarounds

apparently theres another couple of checks but I'll just take a look through and see exactly what they are

ewoud: <https://github.com/voxpupuli/beaker/pull/1767> all done

bastelfreak: the require statement isn't entirely sorted :(

bastelfreak: what I normally do in vim is use visual line mode to select lines and then use :sort