https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • c
    please
  • b
    at least the two gems from mmckinst block our rollout of puppet-lint 3 and I think there's another puppet-lint extension with that problem
  • v
    bastelfreak: yes, https://github.com/hostnet/puppet-lint-param-types/pull/1 did have discussion about moving it
  • a
    puppet-lint is MIT?
  • b
    oh indeed
  • a
    so I don't think we can just grab Apache licensed code and shove it in there (without the author's permission to relicense).
  • c
    yes - it was written by Tim originally and we forked it
  • s
    This message was deleted.
    c
    • 2
    • 1
  • a
    I meant relicensing the plugins.
  • a
    far too many authors in puppet-lint itself to try and relicense that.
    🧌 1
  • v
    so before I knew there was already a legacy fact check I did write https://github.com/ekohl/puppet-lint-legacy_fact-check (and yes, fact vs facts is confusing)
  • v
    if it helps, we could use that as a base and merge it in puppet-lint itself
  • s
    This message was deleted.
    c
    • 2
    • 3
  • a
    I think with voxpupuli-puppet-lint-plugin-forks we can make the intention clear that it's just a holding space for plugins until/if the original author reappears.
  • c
    and possibly the forks thing becomes another initiative along side
  • c
    we probably wouldn’t include that directly in pdk-templates
  • a
    pdk templates includes the vox metadata gem, and that would likely be updated to reference the new forks gem and drop the old unmaintained versions.
  • b
    yes
  • c
    gotcha
  • a
    The main issue currently being that they depend on puppet-lint < 3.
  • b
    which we can easily fix with voxpupuli-puppet-lint-plugin-forks
  • c
    Our main thing is that we can get things fixed quickly when stuff breaks… and if the forks gem works for you, it works for us. I’d also like to look in to Ewouds suggestion https://puppetcommunity.slack.com/archives/C0W1Y5VL0/p1676376424524129
  • c
    this is great.. vox moves FAST
  • c
    thank you 🙏
  • b
    Move fast and break things is the motto!
    🙈 1
    ❤️ 1
  • b
    hides
  • b
  • b
    meena @rnelson0 I still cary on your quotes
    ❤️ 1
  • v
    I don't have time to submit a PR to puppet-lint now, but I'd be happy to give approval to include my legacy fact plugin in puppet-lint, but someone should probably finish it (AFAIK it's still incomplete, see various TODOs)
  • b
    should we move fardward with voxpupuli-puppet-lint-plugin-forks then? I think that's quite easy to implement and if we later on want to swap the legacy fact check with the one from ewoud, we can still do that
1...295296297...648Latest