https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • a

    Alex Fisher

    02/14/2023, 11:57 AM
    maybe 'vox' or 'voxpupuli' should be in the gem name somewhere?
  • b

    bastelfreak

    02/14/2023, 11:57 AM
    voxpupuli-puppet-lint-check-collection?
  • a

    Alex Fisher

    02/14/2023, 11:58 AM
    naming things is hard.
  • b

    bastelfreak

    02/14/2023, 11:58 AM
    voxpupuli-puppet-lint-plugins is our metagem
  • b

    bastelfreak

    02/14/2023, 11:58 AM
    we could also add it just there?
  • b

    bastelfreak

    02/14/2023, 11:58 AM
    or should it be a dedicated gem?
  • b

    bastelfreak

    02/14/2023, 11:58 AM
    mhm dedicated is probably better
  • a

    Alex Fisher

    02/14/2023, 11:58 AM
    voxpupuli-puppet-lint-plugin-forks?
  • b

    bastelfreak

    02/14/2023, 11:58 AM
    ah nice
  • a

    Alex Fisher

    02/14/2023, 11:59 AM
    We could add them there if you update the license to match the incoming code (since the meta gem doesn't really contain anything other than a short list of gems at the moment, updating changing its license wouldn't be an issue)
  • b

    bastelfreak

    02/14/2023, 12:00 PM
    ah right
  • a

    Alex Fisher

    02/14/2023, 12:00 PM
    Do we need to mark our gem as 'conflicting' somehow with the originals?
  • v

    VoxBot

    02/14/2023, 12:00 PM
    are you suggesting to vendor the lint checks?
  • b

    bastelfreak

    02/14/2023, 12:00 PM
    so probably voxpupuli-puppet-lint-plugin-forks with Apache is best. that's what the plugins from mmckinst use as well
  • b

    bastelfreak

    02/14/2023, 12:01 PM
    I would like to pull in the checks from https://github.com/mmckinst/puppet-lint-top_scope_facts-check/ and https://github.com/mmckinst/puppet-lint-legacy_facts-check/ into a new gem
  • b

    bastelfreak

    02/14/2023, 12:01 PM
    I would like to pull in the checks from https://github.com/mmckinst/puppet-lint-top_scope_facts-check/ and https://github.com/mmckinst/puppet-lint-legacy_facts-check/ into a new gem
  • a

    Alex Fisher

    02/14/2023, 12:01 PM
    ewoud: vendor the ones we need to fix but where we can't get hold of the original maintainer.
  • v

    VoxBot

    02/14/2023, 12:01 PM
    just another thought: perhaps do it in puppet-lint itself?
  • b

    bastelfreak

    02/14/2023, 12:01 PM
    because they have open bugs and the maintainer is MIA and we cant release the fixes
  • b

    bastelfreak

    02/14/2023, 12:01 PM
    I think getting a puppet-lint release out is more complex
  • b

    bastelfreak

    02/14/2023, 12:01 PM
    @Craig Gumbley ^
  • v

    VoxBot

    02/14/2023, 12:01 PM
    https://github.com/puppetlabs/puppet-lint/tree/main/lib/puppet-lint/plugins are there and these are according to the Puppet style guide
  • v

    VoxBot

    02/14/2023, 12:01 PM
    so it fits puppet-lint itself
  • v

    VoxBot

    02/14/2023, 12:02 PM
    things like whitespace are more opionated, but using current (non-legacy) facts should be in the Puppet style guide since it prepares for Puppet 8
  • a

    Alex Fisher

    02/14/2023, 12:02 PM
    I tend to agree about the velocity of releases though.
  • c

    Craig Gumbley

    02/14/2023, 12:02 PM
    fwiw its not hard to release puppet-lint 🙂
  • c

    Craig Gumbley

    02/14/2023, 12:02 PM
    not now anyway
  • v

    VoxBot

    02/14/2023, 12:03 PM
    license may be tricky there, but IMHO we should get back to the principle that puppet-lint has all the checks for the official Puppet best practices
  • c

    Craig Gumbley

    02/14/2023, 12:03 PM
    YES
  • c

    Craig Gumbley

    02/14/2023, 12:03 PM
    1000000000%
1...294295296...648Latest