# voxpupuli
- s
Slackbot
02/09/2023, 3:25 PMThis message was deleted.j- 2
- 1
- v
VoxBot
02/09/2023, 3:49 PMgood morning - v
VoxBot
02/09/2023, 3:50 PMDaneel: o/ - v
VoxBot
02/09/2023, 3:51 PMi was trying to add Ubuntu2204 to ferm module but the CI looks to have some trouble. We are getting error message lookking as a GH action trouble : https://github.com/voxpupuli/puppet-ferm/actions/runs/4135806063/jobs/7148936400#step:5:94 - v
VoxBot
02/09/2023, 3:51 PMbastelfreak: o/ - v
VoxBot
02/09/2023, 3:53 PMi don't know if and where, it is possible to get a global vue about all jobs for all modules - v
VoxBot
02/09/2023, 4:00 PMI didn't push much effort into it recently because iptables is deprecated and modern distributions don't have that and/or ferm anymore - v
VoxBot
02/09/2023, 4:00 PMcan I get a review for https://github.com/voxpupuli/voxpupuli-test/pull/85 and https://github.com/voxpupuli/voxpupuli-test/pull/84 - v
VoxBot
02/09/2023, 4:01 PMDaneel: mhm that looks odd - v
VoxBot
02/09/2023, 4:01 PMdid we break that with the recent gha-puppet change - v
VoxBot
02/09/2023, 4:02 PMDaneel: https://github.com/voxpupuli/gha-puppet/pull/22 probably this broke it, but I don't know why - v
VoxBot
02/09/2023, 4:03 PMI'm quite sure we validated the metadata2gha output before - v
VoxBot
02/09/2023, 4:10 PMcan I get a review for https://github.com/voxpupuli/voxpupuli-puppet-lint-plugins/pull/29 - v
VoxBot
02/09/2023, 4:25 PMi don't use GH action at work we are using Gitlab - v
VoxBot
02/09/2023, 4:26 PMi could be interresting to read some docs - v
VoxBot
02/09/2023, 4:26 PMmy problem is time resource - j
jhoblitt
02/09/2023, 5:47 PMCan we talk about the
cop? This drives me absolutely insane.Style/TrailingCommaInArguments: Avoid comma after the last parameter of a method call. - v
VoxBot
02/09/2023, 5:49 PMdon't we set it to prefer a trailing comma? - j
jhoblitt
02/09/2023, 5:49 PMno, it is removing trailing commas now - j
jhoblitt
02/09/2023, 5:52 PMthe style isn't configured: https://github.com/voxpupuli/voxpupuli-test/blob/master/rubocop.yml#L328-L329 - j
jhoblitt
02/09/2023, 5:52 PMthe style isn't configured: https://github.com/voxpupuli/voxpupuli-test/blob/master/rubocop.yml#L328-L329 - v
VoxBot
02/09/2023, 5:52 PMah, IMHO a bug :( - j
jhoblitt
02/09/2023, 5:52 PMI'll PR it then - j
jhoblitt
02/09/2023, 5:53 PMI think we want
? https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/TrailingCommaInArgumentsconsisten_comma - v
VoxBot
02/09/2023, 5:55 PMyes - v
VoxBot
02/09/2023, 6:02 PMI think in the past we discussed it and didnt do it because we would need to fix most of our spec files - j
jhoblitt
02/09/2023, 6:15 PMwell a) my sanity b) my sanity c) my sanity d) community norms... - j
jhoblitt
02/09/2023, 6:15 PMwhat is going on with gha in that repo? - v
VoxBot
02/09/2023, 6:23 PMPuppet up to 6.29 allowed every concurrent-ruby version. latest concurrent-ruby doesnt work with ruby 2.5. Puppet 6.29 pulls in an older concurrent-ruby version - v
VoxBot
02/09/2023, 6:23 PMI fixed that in https://github.com/voxpupuli/voxpupuli-test/pull/85