https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
  • y
    I’d like to start fixing rubocop issues which is kind of blocked by https://github.com/voxpupuli/beaker-docker/pull/72.. I can start in another branch though..
  • y
    I’d like to start fixing rubocop issues which is kind of blocked by https://github.com/voxpupuli/beaker-docker/pull/72.. I can start in another branch though..
  • y
    Any reason we have the 
    Gemfile.local
    not merged into the 
    Gemfile
    here? https://github.com/voxpupuli/beaker-docker/blob/master/Gemfile.local
  • y
    Any reason we have the 
    Gemfile.local
    not merged into the 
    Gemfile
    here? https://github.com/voxpupuli/beaker-docker/blob/master/Gemfile.local
  • y
    I’d not expect a Gemfile.local to be in a git repo btw..
  • y
    I’d not expect the Gemfile.local to be in a git repo btw..
  • y
    I’d not expect a Gemfile.local to be in a git repo btw..
  • y
    I guess I’ll follow the beaker-gke and beaker-hcloud Gemfiles and remove Gemfile.local from the beaker-docker git repo..
  • y
    meh.. they have quite different approaches.. one has everything in a gemspec, another in a Gemfile..
  • b
    @Yury Bushmelev the idea was to have an identical Gemfile in all beaker plugins
  • b
    I think I once started modulesync_config_beaker to clean it up different plugins 🤔
  • y
    Hmm.. let me know which one is best example to follow then :)
  • b
    I would just keep the Gemfile.local
  • b
    and fix some of the rubocoo violations
  • y
    I don’t like that because we already have gems spread across Gemfile and gemspec :)
  • y
    Then beaker-rspec should be required to test any hypervisor I guess.. so better to merge
  • y
    As beaker is in gemspec I’d say beaker-rspec is dev dependency
  • b
    maybe it makes sense to add it as a development dependency to the gemspec
  • y
    Bingo! Will do that then :)
  • y
    does the 
    docs:*
    tasks make sense for 
    beaker-docker
    Rakefile? I don’t see 
    yard
    in Gemfile/gemspec
  • y
    beaker-gke and beaker-hcloud doesn’t have such tasks in their Rakefiles
  • b
    this could be an ancient leftover from Puppet
  • y
    well.. maybe I’ll keep it for now and we can drop it later (I see it in some other old beaker hypervisor drivers as well)
  • b
    yeah. I try to avoid touching code I don't understand / don't know if it's still used
  • y
    trying to use 
    on(host, 'ls /tmp/yum.log || true') { |res| it { is_expected(res.stdout).to match(/yum.log/) } }
    though it doesn’t seems to work.. it looks like beaker DSL is completely unrelated to RSpec one..
  • y
    example above is a bit naive but I’m just trying to make it working in any way
  • y
    ah.. it seems it is Minitest-based actually..
  • y
    well.. I cleaned up some rubocop issues and did some small improvements here: https://github.com/voxpupuli/beaker-docker/pull/75.. though the actual 
    beaker-docker
    hypervisor driver and its spec was not touched this time to reduce amount of changes.
  • y
    well.. I cleaned up some rubocop issues and did some small improvements here: https://github.com/voxpupuli/beaker-docker/pull/75.. though the actual 
    beaker-docker
    hypervisor driver and its spec was not touched this time to reduce amount of changes.
1...225226227...648Latest