https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • y

    Yury Bushmelev

    12/21/2022, 11:45 AM
    what is the oldest ruby version supported by voxpupuli gems? 2.8?
  • y

    Yury Bushmelev

    12/21/2022, 11:46 AM
    what is the oldest ruby version supported by voxpupuli gems? 2.4?
  • b

    bastelfreak

    12/21/2022, 11:46 AM
    it depends 😄
  • b

    bastelfreak

    12/21/2022, 11:47 AM
    2.4 to 2.7 usually. check the gemspec file for the individual gems
  • y

    Yury Bushmelev

    12/21/2022, 11:49 AM
    ok, so I’ll require rubocop 1.12.2 as latest version supporting ruby 2.4
    👍 1
  • y

    Yury Bushmelev

    12/21/2022, 12:43 PM
    Copy code
    ➜  beaker-docker git:(rubocop) ✗ grep -c '^[^# ]' .rubocop_todo.yml
    90
  • y

    Yury Bushmelev

    12/21/2022, 12:47 PM
    Copy code
    ➜  beaker-docker git:(rubocop) ✗ bundle exec rubocop -c /dev/null -fj | jq .summary
    {
      "offense_count": 760,
      "target_file_count": 10,
      "inspected_file_count": 10
    }
  • y

    Yury Bushmelev

    12/21/2022, 12:48 PM
    not bad notbad
  • y

    Yury Bushmelev

    12/21/2022, 12:50 PM
    https://github.com/voxpupuli/metadata-json-lint/blob/master/.rubocop.yml#L3 <- this one is false I guess..
  • y

    Yury Bushmelev

    12/21/2022, 12:50 PM
    https://github.com/voxpupuli/metadata-json-lint/blob/master/.rubocop.yml#L3 <- this one is false I guess..
  • b

    bastelfreak

    12/21/2022, 12:57 PM
    yep :D
  • y

    Yury Bushmelev

    12/21/2022, 1:59 PM
    hm.. some GH actions were cancelled 🤔
  • y

    Yury Bushmelev

    12/21/2022, 1:59 PM
    @bastelfreak could you pls have a look here: https://github.com/voxpupuli/beaker-docker/pull/72?
  • y

    Yury Bushmelev

    12/21/2022, 1:59 PM
    @bastelfreak could you pls have a look here: https://github.com/voxpupuli/beaker-docker/pull/72?
  • b

    bastelfreak

    12/21/2022, 2:00 PM
    they were cancelled because the first one failed
  • b

    bastelfreak

    12/21/2022, 2:02 PM
    do you have some stuff in the rubocop_todo that's only supported by newer rubocop versions?
  • b

    bastelfreak

    12/21/2022, 2:02 PM
    yes
  • b

    bastelfreak

    12/21/2022, 2:02 PM
    # on 2022-12-21 131856 UTC using RuboCop version 1.41.0.
  • v

    VoxBot

    12/21/2022, 2:17 PM
    ewoud: thanks!
  • v

    VoxBot

    12/21/2022, 2:35 PM
    bastelfreak: I saw you updated a lot of modulesync, but perhaps we should nominate modules to retire them
  • v

    VoxBot

    12/21/2022, 2:35 PM
    like puppet-staging
  • d

    Dr Bunsen Honeydew

    12/21/2022, 2:35 PM
    See the
    puppet-staging
    module at https://forge.puppet.com/puppet/staging?src=slack&amp;channel=voxpupuli
  • v

    VoxBot

    12/21/2022, 2:35 PM
    yep
  • v

    VoxBot

    12/21/2022, 2:36 PM
    and puppet-tea
  • d

    Dr Bunsen Honeydew

    12/21/2022, 2:36 PM
    See the
    puppet-tea
    module at https://forge.puppet.com/puppet/tea?src=slack&amp;channel=voxpupuli
  • v

    VoxBot

    12/21/2022, 2:38 PM
    perhaps it's somethig we can discuss at cfgmgmtcamp
  • v

    VoxBot

    12/21/2022, 2:43 PM
    https://github.com/voxpupuli/puppet-nsd/pull/45 I think that should pass now
  • v

    VoxBot

    12/21/2022, 2:47 PM
    https://github.com/voxpupuli/modulesync_config/pull/803
  • y

    Yury Bushmelev

    12/21/2022, 6:42 PM
    ok, all checks are green here: https://github.com/voxpupuli/beaker-docker/pull/72 (rubocop-related PR)
  • y

    Yury Bushmelev

    12/21/2022, 6:42 PM
    ok, all checks are green here: https://github.com/voxpupuli/beaker-docker/pull/72 (rubocop-related PR)
1...224225226...648Latest