I would like to change the default branch in voxpupuli/pypuppetdb and voxpupuli/puppetboard from “master” to “main”. any objections?

I kind of do - almost all our branches use master and I really hate it when some use master and others main

personally I never really understood why the whole rename was needed - I always interpreted it as virtue signalling

the question should be: why was it ever master to begin with

good question, but searching for "origin of git master" is … useless

I guess because "trunk" as SVN used it was a poor choice

and master is used in so many places, like master copy

but even participating in the discussion is hazardous in many places so I mostly try to avoid it

I guess in Finland nobody knows that word “master” may even hurt anyone

Especially at time of the

git

tool design

Especially at time of the

git

tool design

Just saw the warning.. not sure where to report it (if report at all):

/Users/jay/.pdk/cache/ruby/2.7.0/gems/beaker-rspec-7.1.0/lib/beaker-rspec/helpers/serverspec.rb:43: warning: already initialized constant Module::VALID_OPTIONS_KEYS
/opt/puppetlabs/pdk/share/cache/ruby/2.7.0/gems/specinfra-2.82.2/lib/specinfra/configuration.rb:4: warning: previous definition of VALID_OPTIONS_KEYS was here

Another question.. I’m trying to find a place where

beaker

rake tasks are defined.. from https://github.com/voxpupuli/voxpupuli-acceptance/blob/master/lib/voxpupuli/acceptance/rake.rb I see it just imports

beaker-rspec

one.. which is here https://github.com/voxpupuli/beaker-rspec/blob/master/lib/beaker-rspec/rake_task.rb.. which defined a

beaker

task which I cannot understand.. I definitely miss another place or implicitly included something

Another question.. I’m trying to find a place where

beaker

rake tasks are defined.. from https://github.com/voxpupuli/voxpupuli-acceptance/blob/master/lib/voxpupuli/acceptance/rake.rb I see it just imports

beaker-rspec

one.. which is here https://github.com/voxpupuli/beaker-rspec/blob/master/lib/beaker-rspec/rake_task.rb.. which defined a

beaker

task which I cannot understand.. I definitely miss another place or implicitly included something

I meant those tasks below:

rake beaker                                                                                                # Run beaker acceptance tests / Run RSpec code examples
rake beaker:sets                                                                                           # List available beaker nodesets
rake beaker:ssh[set,node]                                                                                  # Try to use vagrant to login to the Beaker node

Ah.. well.. I was able to understand the beaker-rspec rake task now.. I missed it’s

RSpec::Core::RakeTask

Found an issue in beaker-docker: https://github.com/voxpupuli/beaker-docker/blob/master/lib/beaker/hypervisor/docker.rb#L81

Creating container from image ba67b51e73d0
post
/containers/create
{"name"=>"beaker-ubuntu2004-AARCH64-1-cc9172827395"}
{"Image":"ba67b51e73d0","Hostname":"ubuntu2004-AARCH64-1","HostConfig":{"PortBindings":{"22/tcp":[{"HostPort":"0845","HostIp":"0.0.0.0"}]},"PublishAllPorts":true,"RestartPolicy":{"Name":"always"},"Privileged":true}}

See the

HostPort

which is below 1024.. I’d say it’s better to always generate ports above 1024

Found an issue in beaker-docker: https://github.com/voxpupuli/beaker-docker/blob/master/lib/beaker/hypervisor/docker.rb#L81

Creating container from image ba67b51e73d0
post
/containers/create
{"name"=>"beaker-ubuntu2004-AARCH64-1-cc9172827395"}
{"Image":"ba67b51e73d0","Hostname":"ubuntu2004-AARCH64-1","HostConfig":{"PortBindings":{"22/tcp":[{"HostPort":"0845","HostIp":"0.0.0.0"}]},"PublishAllPorts":true,"RestartPolicy":{"Name":"always"},"Privileged":true}}

See the

HostPort

which is below 1024.. I’d say it’s better to always generate ports above 1024

What’s wrong with this:

ubuntu2004-AARCH64-1 was given a port less than 1024 but you are connecting to a rootless instance, retrying

And to add more confusion.. this command executes test twice:

BEAKER_setfile='ubuntu2004-AARCH64' pdk bundle exec rake beaker

is it expected?

in Vox Pupuli we never use PDK

perhaps you can share the steps you're running

btw, you can also simply run BEAKER_setfile bundle exec rspec spec/acceptance/my_spec.rb

it really is a true rspec test

pdk bundle

is just wrapper around bundler which is bundled with PDK 🙂

hmm.. well,

BEAKER_setfile='ubuntu2004-AARCH64' pdk bundle exec rspec --pattern "spec/acceptance/**/*_spec.rb"

runs the suite once 🤔

hmm.. well,

BEAKER_setfile='ubuntu2004-AARCH64' pdk bundle exec rspec --pattern "spec/acceptance/**/*_spec.rb"

runs the suite once 🤔

but

rake beaker

runs this twice by some reason..

/opt/puppetlabs/pdk/private/ruby/2.7.6/bin/ruby -I/Users/jay/.pdk/cache/ruby/2.7.0/gems/rspec-core-3.12.0/lib:/Users/jay/.pdk/cache/ruby/2.7.0/gems/rspec-support-3.12.0/lib /Users/jay/.pdk/cache/ruby/2.7.0/gems/rspec-core-3.12.0/exe/rspec --pattern spec/acceptance/\*\*/\*_spec.rb

though.. same-same but different.. first run is with different pattern..

/opt/puppetlabs/pdk/private/ruby/2.7.6/bin/ruby -I/Users/jay/.pdk/cache/ruby/2.7.0/gems/rspec-core-3.12.0/lib:/Users/jay/.pdk/cache/ruby/2.7.0/gems/rspec-support-3.12.0/lib /Users/jay/.pdk/cache/ruby/2.7.0/gems/rspec-core-3.12.0/exe/rspec spec/acceptance