god no

ah yes. so version is defined in the init.pp and params.pp doesnt know that because it is evaluated befire init.pp

ahhhhhhh

that's the bit I'm missing, BEFORE

so $version should be moved to init.pp

oh wait

it's in init.pp

at least I think so, because init.pp inherits params.pp

*should b3 moved to params.pp, not init, sorry :D

shouldnt type and cook

I may need to look at this again then, as params.pp is not setting version, it's getting it from init.pp (or where it's set say hiera)

you're cooking, I'm distracting you, go do that

check $manage_repo for example

thnaks

defined in params.pp, referenced in init.pp

yeah, that's how I have it now, but I managed to get it working without that (it shouldn't work) hence my interest

are their plans or discussion regarding dropping params.pp and move to module hiera data?

are their plans or discussion regarding dropping params.pp and move to module hiera data?

@tuxmea I did this from time to time to a few modules, and as far as i can tell the situation was always better after than before so for me: 💯 ! But I do not thing there was a discussion about if we want to "nomalize" one way or the other.

s/thing/think/

for new parameters we require them to be defined in init.pp, not params.pp

good approach for new parameters. any idea in how to automate hiera examples? or should these be part of the readme? or do we refer people to reference?

when puppet was in early versions, didn't params used to be in init.pp then the module changed where everyone insisted they where in params.pp

that were the old and oldold days!

"model" changed, not module

I'm thinking puppet 3-ish time

everything that is static should go into init.pp, because puppet-lint will pick it up for the reference.md

Regarding hiera examples (you are talking about documentation in REAME.md right?), my personal opinion: kill it with fire 🔥(They are barely readable and my feeling is that if you do put everything in hiera, you will know how to translate a puppet configuration in some yaml mess)