oh, are you saying it wasn't even valid before? Oops.

I'd also suggest a helper function so you can use something like apache_unified_access($zabbix_api_access), but I'm not sure how generic that would be

I suggest to only support apache 2.4

we're just playing the theory game here ;)

I just want to be sure :D

@tvaughan It's valid with or without the parentheses. I guess they would coerce the strict indent plugin into being happy though!

Yeah, that was the idea

Wednesday Puppet golf.

It looks less horribad 😄

ha, maybe. Pretty subjective though. I dislike redundant parentheses (I have colleagues who seem to add them everywhere!) And not having them aligns a bit better with the ruby style guide we follow for our facts/types/functions/tests etc.

I’d use intermediate variable (or function as suggested above) in the code

afisher: do you have LISP programmers as colleagues? ;)))

(((

Opening parentheses (sorry) :)

(

@bastelfreak are you round ?

always

how can I help /what did I break

you posted a really helpful comment in a premature PR from me, took it to heart and fixed it, but while I was working it through I had a situation where the class was 'working' when it shouldn't be, and wondered if you could just clarify your comment a little for me to see if I've miss-understood,

it was against the puppet-consul module and the version parameter set in init.pp not being available to the parms.pp class

See the

puppet-consul

module at https://forge.puppet.com/puppet/consul?src=slack&channel=voxpupuli

yeah

if I reference consul::version as the parameter in params.pp - why would params.pp not be aware of "version"

I'm looking at install.pp and that evaluates consul::version in that class without having it set locally

so I wasn't sure if I'd miss-understood your comment or just not understood how data is encapsulated in general

do you have a link to the pr?

did we meege that already?

*merge

I do, it's closed as it was premature,