https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • a
    ewoud: Is it possible to get metadata2gha to skip older puppet versions even if they do appear in metadata.json?
  • a
  • v
    I suppose so, though I wonder what is desired
  • v
    I don't like silently ignoring things - perhaps with an explicit "--i-know-what-i-am-doing" style flag?
  • a
    yeah, I'm not sure on a sane implementation.
  • v
    or a --min-puppet-version parameter where you can use --min-puppet-version 6 to test on >= 6
  • v
    if it's not passed it uses the lower bound from metadata.json
  • v
    if it is passed and the lower bound in metadata.json is higher (so param is 6, metadata.json is 7) it raises an error
  • a
    dunno if you need to raise an error
  • v
    I don't like a redundant parameter since that can only confuse people and raising an error ensures that when you raise it in metadata.json, you must drop (or adjust) it
  • a
  • a
  • v
    so perhaps even when it's >= instead of >
  • a
    I'm not sure who might use that but not use a recent voxpupuli-test gem
  • v
    right, so you'd probably define an input on the job that gets translated to something (env var, parameter) and then in the "caller" you pass the input
  • v
    https://github.com/voxpupuli/gha-puppet#basic-tests similar to how we can pass the rubocop: false part there
  • a
    Thanks. I'll see what I can come up with and then decide whether it's worth the hassle! 🙂
  • a
    ewoud: My attempt so far is nasty... passing 'minimum_puppet_version' around everywhere starting here https://github.com/voxpupuli/puppet_metadata/blob/master/lib/puppet_metadata/github_actions.rb#L11
  • a
    ewoud: My attempt so far is nasty... passing 'minimum_puppet_version' around everywhere starting here https://github.com/voxpupuli/puppet_metadata/blob/master/lib/puppet_metadata/github_actions.rb#L11
  • a
    I never am too sure when to use instance variables instead. Maybe here?
  • v
    good question since it's one of the hard problems in engineering IMHO
  • v
    at some point it may be easier to pass around an object with settings I guess
  • s
    o/ @Alex Fisher @bastelfreak oh, I lost this release improvements from my field of view. Adding this to the things to sort out at $WORK
  • v
    okay, so i'm trying to do a full mesh setup with puppet-wireguard, and it's breaking my brain
  • d
  • v
    i'm trying to use exported resources to have each peer talk to each other, but then i can't figure out how to extract the right public key
  • v
    ... since i don't know the name of the tunnel, because i don't know who i'm peering with
  • v
    bastelfreak: how do you configure your wireguard tunnels? manually, for each point to point link?
  • v
    my "problem" is that all my peers are not controlled by my Puppet
  • v
    so I cannot use exported resources
1...176177178...648Latest