https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • b

    bastelfreak

    11/02/2022, 10:26 AM
    (@smortex is working on improving this)
  • a

    Alex Fisher

    11/02/2022, 10:27 AM
    yes, I was thinking that it wasn't especially interesting as it's mostly just noise from a recent puppet-strings update.
  • a

    Alex Fisher

    11/02/2022, 10:27 AM
    Ideally, the tag would be on the 'Release X' merge commit, but if it's only the REFERENCE.MD changing, (and in non important ways), it probably doesn't matter??
  • b

    bastelfreak

    11/02/2022, 10:28 AM
    IMO it's not that important
  • a

    Alex Fisher

    11/02/2022, 10:28 AM
    I think, if anything, we probably want the release PR to fail if the file is out of date??
  • b

    bastelfreak

    11/02/2022, 10:28 AM
    yes it would be nice, but that's about it
  • b

    bastelfreak

    11/02/2022, 10:29 AM
    https://github.com/voxpupuli/voxpupuli-release/pull/44 is the PR from @smortex
  • b

    bastelfreak

    11/02/2022, 10:29 AM
    https://github.com/voxpupuli/voxpupuli-release/pull/44 is the PR from @smortex
  • b

    bastelfreak

    11/02/2022, 10:29 AM
    tl;dr update it during changelog generation
  • a

    Alex Fisher

    11/02/2022, 10:29 AM
    ok. I'll just YOLO it this time.
  • a

    Alex Fisher

    11/02/2022, 10:33 AM
    Maybe we need to change our minimum
    puppet-strings
    version to 3? (To stop any flapping between before and after eg. https://github.com/puppetlabs/puppet-strings/pull/303
  • a

    Alex Fisher

    11/02/2022, 10:33 AM
    Maybe we need to change our minimum
    puppet-strings
    version to 3? (To stop any flapping between before and after eg. https://github.com/puppetlabs/puppet-strings/pull/303
  • b

    bastelfreak

    11/02/2022, 10:34 AM
    good idea
  • b

    bastelfreak

    11/02/2022, 10:37 AM
    https://github.com/voxpupuli/modulesync_config/pull/800
  • b

    bastelfreak

    11/02/2022, 10:37 AM
    https://github.com/voxpupuli/modulesync_config/pull/800
  • a

    Alex Fisher

    11/02/2022, 10:47 AM
    Any day you get to quote 'The Princess Bride' is a good day. https://github.com/voxpupuli/voxpupuli-release/pull/47
  • a

    Alex Fisher

    11/02/2022, 10:47 AM
    Any day you get to quote 'The Princess Bride' is a good day. https://github.com/voxpupuli/voxpupuli-release/pull/47
  • v

    VoxBot

    11/02/2022, 10:48 AM
    ♥️
  • v

    VoxBot

    11/02/2022, 10:48 AM
    love that quote
  • a

    Alex Fisher

    11/02/2022, 10:54 AM
    I think https://github.com/voxpupuli/puppet-puppet_certificate/pull/11 is ready for merge. I'd like to get a release out and then start my next refactor (I'm going to split the code into 2 separate providers)
  • a

    Alex Fisher

    11/02/2022, 10:54 AM
    I think https://github.com/voxpupuli/puppet-puppet_certificate/pull/11 is ready for merge. I'd like to get a release out and then start my next refactor (I'm going to split the code into 2 separate providers)
  • a

    Alex Fisher

    11/02/2022, 11:58 AM
    @bastelfreak Copy and paste? https://github.com/voxpupuli/puppet-consul/pull/593/files#r1011640970 ??
  • b

    bastelfreak

    11/02/2022, 12:01 PM
    🤫
    😄 1
  • b

    bastelfreak

    11/02/2022, 12:01 PM
    will fix that later
  • a

    Alex Fisher

    11/02/2022, 12:05 PM
    I was looking for some boilerplate to steal for puppet_certificate at the time and randomly picked on that.
  • b

    bastelfreak

    11/02/2022, 12:16 PM
    @Alex Fisher https://github.com/voxpupuli/puppet-consul/pull/619
    👍 1
  • b

    bastelfreak

    11/02/2022, 12:16 PM
    @Alex Fisher https://github.com/voxpupuli/puppet-consul/pull/619
  • a

    Alex Fisher

    11/02/2022, 12:20 PM
    Cool. Dunno if you want to have a quick scan for any other modules this text made it to??
  • b

    bastelfreak

    11/02/2022, 12:24 PM
    https://github.com/voxpupuli/puppet-vault/pull/15
  • b

    bastelfreak

    11/02/2022, 12:24 PM
    https://github.com/voxpupuli/puppet-vault/pull/15
1...175176177...648Latest