https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • b

    bastelfreak

    08/09/2022, 10:41 AM
    can you put one of the errors in a paste service?
  • r

    Rathios

    08/09/2022, 10:42 AM
    Sure can do. This is the first one https://gist.github.com/Rathios/305be864c63e67e707eba8c6c594ddb0
  • v

    VoxBot

    08/09/2022, 10:42 AM
    can you share more? like the command you ran?
  • r

    Rathios

    08/09/2022, 10:46 AM
    These are the commands I ran in order, from puppet-zabbix directory. I think at this point Gemfile.lock was still from the attempt with 3.0.4, but I got no warnings from bundle install
    Copy code
    $ rbenv install 2.7.6
    $ rbenv global 2.7.6
    $ rbenv local 2.7.6
    $ ruby --version
    ruby 2.7.6p219 (2022-04-12 revision c9c2245c0a) [x86_64-linux]
    $ gem install bundler
    $ bundle install
    $ overcommit --install
    $ bundle exec rake test
  • r

    Rathios

    08/09/2022, 10:47 AM
    These are the commands I ran in order, from puppet-zabbix directory. I think at this point Gemfile.lock was still from the attempt with 3.0.4, but I got no warnings from bundle install
    Copy code
    $ rbenv install 2.7.6
    $ rbenv global 2.7.6
    $ rbenv local 2.7.6
    $ ruby --version
    ruby 2.7.6p219 (2022-04-12 revision c9c2245c0a) [x86_64-linux]
    $ gem install bundler
    $ bundle install
    $ overcommit --install
    $ bundle exec rake test
  • r

    Rathios

    08/09/2022, 10:47 AM
    Command output was lost to terminal buffer from all the tests. I can re-run from scratch if you need that
  • r

    Rathios

    08/09/2022, 10:50 AM
    This be on Fedora 36 kernel 5.18.5-200.fc36.x86_64
  • v

    VoxBot

    08/09/2022, 10:57 AM
    for context, I also run on Fedora 36 and with export RUBYOPT=-W0 you disable the ERB deprecation warnings
  • v

    VoxBot

    08/09/2022, 10:58 AM
    from there on it works for me
  • r

    Rathios

    08/09/2022, 10:59 AM
    Roger. Hmm. I wonder what is interfering with the tests.
  • r

    Rathios

    08/09/2022, 10:59 AM
    This machine was first installed with Fedora 22 something. It's been upgraded a lot
  • v

    VoxBot

    08/09/2022, 11:01 AM
    hmm, now that I say that I do see test failures
  • v

    VoxBot

    08/09/2022, 11:05 AM
    it fails because of a change in puppetlabs-postgresql - it relies on a custom fact that isn't set in the test env
  • v

    VoxBot

    08/09/2022, 11:05 AM
    this has nothing to do with the Ruby version
  • f

    fe80

    08/09/2022, 11:06 AM
    https://github.com/voxpupuli/puppet-zabbix/pull/824/files
  • f

    fe80

    08/09/2022, 11:06 AM
    I've try to fix that on the pr, but functional test not work
  • v

    VoxBot

    08/09/2022, 11:06 AM
    that's the wrong approach
  • v

    VoxBot

    08/09/2022, 11:08 AM
    https://github.com/voxpupuli/puppet-zabbix/pull/834/files#diff-89eebfcbc0f14b6d989517837ca1e94fce4e2ce9a03233641cd936f2b8d2ed94 that should address it
    👍 1
  • v

    VoxBot

    08/09/2022, 11:11 AM
    bleh, there are more mistakes in the spec tests
  • r

    Rathios

    08/09/2022, 11:12 AM
    Haha gotcha. I'll wait until they are sorted then 🙂
  • r

    Rathios

    08/09/2022, 11:12 AM
    Or help fix them. I can use work hours on this one
  • r

    Rathios

    08/09/2022, 11:16 AM
    I don't see tests covering RHEL8 and RHEL9-like distros. Would you guys consider adding Rocky 8 and 9?
  • v

    VoxBot

    08/09/2022, 11:16 AM
    in most places we use CentOS Stream because that's what we already have acceptance tests for, but I'm not opposed to adding more coverage
  • v

    VoxBot

    08/09/2022, 11:17 AM
    but for acceptance tests we don't have it set up today AFAIK
  • r

    Rathios

    08/09/2022, 11:17 AM
    CentOS Stream would work for me
  • v

    VoxBot

    08/09/2022, 11:17 AM
    we use CentOS in metadata.json for that
  • b

    bastelfreak

    08/09/2022, 11:18 AM
    if someone wants to add rocky/alma support to https://github.com/voxpupuli/puppet_metadata , that would be awesome (that will enable acceptance testing as soon as someone adds it to the metadata.json in a module)
  • b

    bastelfreak

    08/09/2022, 11:18 AM
    if someone wants to add rocky/alma support to https://github.com/voxpupuli/puppet_metadata , that would be awesome (that will enable acceptance testing as soon as someone adds it to the metadata.json in a module)
  • r

    Rathios

    08/09/2022, 11:19 AM
    I could look at that sometime. I switched to Rocky in the home enterprise
  • r

    Rathios

    08/09/2022, 11:21 AM
    My point was though, in that last GitHub action running for your modulesync I don't see any acceptance tests running for any RHEL8-family OSes at all. No CentOS8 Stream etc. So that would be good to get added I think https://github.com/voxpupuli/puppet-zabbix/actions/runs/2824815535
1...120121122...648Latest