Puppet Community

deleted.  i'll comment on the associated PR.

smortex_: i fixed everything you mentioned, thanks for your review <https://github.com/voxpupuli/puppet-wireguard/pull/54>

either way, do you all normally squash &amp; merge or just merge as-is?

"it depends" :smile: , when there are multiple commits and they make sense, I don't squash. When there are some testing commits or a merge commits, I ask the author to rebase + fixup/squash. I squash and merge those only when it's urgent

for this particular PR I'm waiting for feedback from smortex to see if he wants to revert the original PR that introduced the error, or if we should merge #53

fwiw i think it would be a terrible mistake to drop the `interfaces` parameter

<@U1PC2RAH0> i see you approved <https://github.com/voxpupuli/puppet-wireguard/pull/53>.  should i merge it?

Hi there. Someone who can help out an rspec newbie?
1/3 of the tests fail when I run  `bundle exec rake spec` on master branch of puppet-zabbix. I assume it's something wrong with my local setup?
```Finished in 22 minutes 14 seconds (files took 30.66 seconds to load)
6133 examples, 2163 failures```

there should be a long list of errors. can you paste one to <https://gist.github.com/> and share the link?

Will do. I'm gonna run it again just to be sure, without my tiny change

With `bundle exec rake test` on master branch with no local changes. Here's the first few fails: <https://gist.github.com/Rathios/e42083b893656c188d80e25e78b9dbc4>
And the full thing too large for github, minus 116k lines of
```/usr/share/gems/gems/puppet-7.18.0/lib/puppet/parser/templatewrapper.rb:93: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
/usr/share/gems/gems/puppet-7.18.0/lib/puppet/parser/templatewrapper.rb:93: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.```
<https://rawr.no/shared/bundle_test_filtered.txt>

I guess you're on Ruby 3.1 and Puppet doesn't support that well

the fix for that was merged a few hours ago

<https://github.com/puppetlabs/puppet/pull/8918>

Ah, very nice. I suppose the fix is to downgrade Ruby until they have released it

use rbenv, with a ruby release like `2.7.6`

ruby 3 works as well, if you want to use that

ewoud: did you have a local workaround for ruby3.1 + puppet?

that not require `puppet-module-posix-dev-r3.0` ?

if you use a pdk style module, yes. that's why we don't use pdk :slightly_smiling_face:

bastelfreak: yes, set minor_version = '2.7' explicitly in Gemfile

that helps only for pdk modules, doesn'tit?

I don't think we use that in our modules?

oh yes, for Ruby deprecation warnings: export RUBYOPT=-W0

Ruby 3.0.4 and 2.7.6 got rid of the deprecation warnings. Still getting ~2160 failures in each of them though. Something must be borked with my setup

rbenv install &lt;rubyversion&gt; + rbenv local &lt;rubyversion&gt; + gem install bundler + bundle install + bundle exec rake test