# voxpupuli
- p
Pat Riehecky
06/28/2022, 3:56 PMIf that is viable, I'd love a merge and a new version of the module up at the forge.... - v
VoxBot
06/28/2022, 3:57 PMI am not comfortable merging that without knowing / testing how the settings function - v
VoxBot
06/28/2022, 3:57 PMand I don't have time to do that personally - p
Pat Riehecky
06/28/2022, 6:46 PMAny chance to get : https://github.com/voxpupuli/puppet-rhsm/pull/125 https://github.com/voxpupuli/puppet-rhsm/pull/124 into a new forge release? - p
Pat Riehecky
06/28/2022, 6:46 PMAny chance to get : https://github.com/voxpupuli/puppet-rhsm/pull/125 https://github.com/voxpupuli/puppet-rhsm/pull/124 into a new forge release? - v
VoxBot
06/29/2022, 10:47 AMhttps://github.com/puppetlabs/puppetlabs-apache/pull/2256/files it feels good to remove so many lines of code :P - p
Pat Riehecky
06/29/2022, 3:44 PMI was hopeful to get https://github.com/voxpupuli/puppet-logrotate/pull/196 merged in this week so I can focus in on EL8/9 compat updates for it.... - p
Pat Riehecky
06/29/2022, 3:44 PMI was hopeful to get https://github.com/voxpupuli/puppet-logrotate/pull/196 merged in this week so I can focus in on EL8/9 compat updates for it.... - l
Lumiere
06/29/2022, 3:49 PMdoes rspec tests not require => to be lined up? - p
Pat Riehecky
06/29/2022, 3:49 PMrubocop kept putting them back unaligned when I fiddled with them - p
Pat Riehecky
06/29/2022, 3:51 PMI'll try to see if I can get them lined up and happy - l
Lumiere
06/29/2022, 3:54 PMthe other thing I saw was you removed FreeBSD from the metadata support matrix but left the tests for them - l
Lumiere
06/29/2022, 3:54 PMeither way, removing FreeBSD as a supported os will be a major version change - p
Pat Riehecky
06/29/2022, 3:54 PMThe FreeBSD support all works, but when it is in the metadata.json the github actions fail for some reason.... I've no idea why - l
Lumiere
06/29/2022, 3:54 PMthat's probably a question for @bastelfreak - p
Pat Riehecky
06/29/2022, 3:55 PMIdeally I'd like to leave the FreeBSD stuff in there - b
bastelfreak
06/29/2022, 3:58 PMplease readd FreeBSD and then let's check why it fails - b
bastelfreak
06/29/2022, 3:59 PMalso puppet-lint enforces
alignment for Puppet code, but I don't know if rubocop enforces it for Ruby code=> - p
Pat Riehecky
06/29/2022, 4:00 PMPushed version with FreeBSD back in the metadata - b
bastelfreak
06/29/2022, 4:13 PMhttps://github.com/voxpupuli/puppet-logrotate/blob/7716664923a2f4aca4a1eaa86d589d35dbf9db55/spec/classes/init_spec.rb#L18 maybe the lagacy fa ct is missing in the latest facterdb release for freebsd - b
bastelfreak
06/29/2022, 4:13 PMhttps://github.com/voxpupuli/puppet-logrotate/blob/7716664923a2f4aca4a1eaa86d589d35dbf9db55/spec/classes/init_spec.rb#L18 maybe the lagacy fa ct is missing in the latest facterdb release for freebsd - b
bastelfreak
06/29/2022, 4:13 PMI will try to take a look later - r
root-expert
06/29/2022, 4:28 PMhttps://github.com/voxpupuli/voxpupuli-test/commit/00ea471ed8731c5e18ad55ff352de32d72d8cccc After this got merged multiple styles are allowed for => - v
VoxBot
06/29/2022, 4:29 PMah right, yes - v
VoxBot
06/29/2022, 4:32 PMah - b
bastelfreak
06/29/2022, 8:11 PM@Pat Riehecky can you reproduce the issues locally? it passes for me 🤷 - p
Pat Riehecky
06/29/2022, 8:11 PMI don't get the problem locally - b
bastelfreak
06/29/2022, 8:12 PMmhm - m
Marty Ewings
06/30/2022, 10:10 AM@bastelfreak do you have plans for the release of vault lookup anytime soon? https://github.com/voxpupuli/puppet-vault_lookup/pull/51 - m
Marty Ewings
06/30/2022, 10:10 AM@bastelfreak do you have plans for the release of vault lookup anytime soon? https://github.com/voxpupuli/puppet-vault_lookup/pull/51