# voxpupuli
- v
VoxBot
06/24/2022, 9:16 PM - t
tvaughan
06/24/2022, 9:16 PMThanks! - t
tvaughan
06/24/2022, 9:16 PMThat should really be in core 😐 - j
jhoblitt
06/24/2022, 9:17 PMoh, that is fantastic - j
jhoblitt
06/24/2022, 9:17 PM@Alex Fisher ++ - d
Dr Bunsen Honeydew
06/24/2022, 9:17 PMafisher leveled up! (Karma: 5) - b
bastelfreak
06/24/2022, 10:13 PM@tvaughan checkout https://github.com/voxpupuli/voxpupuli-puppet-lint-plugins (and the deps it has)👍 1 - b
bastelfreak
06/24/2022, 10:13 PM@tvaughan checkout https://github.com/voxpupuli/voxpupuli-puppet-lint-plugins (and the deps it has) - g
Greg Dubicki
06/26/2022, 3:11 PMplease check out the proposal for a new major Puppetboard version, v4, here: https://github.com/voxpupuli/puppetboard/pull/697 - g
Greg Dubicki
06/26/2022, 3:11 PMplease check out the proposal for a new major Puppetboard version, v4, here: https://github.com/voxpupuli/puppetboard/pull/697 - v
VoxBot
06/28/2022, 5:47 AMo/ - v
VoxBot
06/28/2022, 5:47 AM - v
VoxBot
06/28/2022, 5:48 AMI asked a coworker for a review on the last one because it is blocking us, but would like an approval from somebody from vox before merging - v
VoxBot
06/28/2022, 9:07 AMhttps://github.com/voxpupuli/puppet-systemd/pull/287#issuecomment-1168434252 someone could weigh in on the naming? systemd::simpletimer vs systemd:⏲️:simple - v
VoxBot
06/28/2022, 9:09 AMwhat makes it "simple"? - v
VoxBot
06/28/2022, 9:10 AMthe fact you need to pass fewer params? - v
VoxBot
06/28/2022, 9:10 AMtechnically more I think, but you don't need to maintain a template - v
VoxBot
06/28/2022, 9:10 AMso it's really a layer on top of systemd::timer - v
VoxBot
06/28/2022, 9:12 AMsystemd:⏲️:generated? - v
VoxBot
06/28/2022, 9:12 AMbecause it's never "simple" or "easy" - v
VoxBot
06/28/2022, 9:13 AMthat makes me think more of guided or templated - v
VoxBot
06/28/2022, 9:13 AMtemplated would also work, yeah - r
root-expert
06/28/2022, 9:23 AMHello, I got a question to see if my concerns are correct: https://github.com/voxpupuli/puppet-vault_lookup/blob/478f5e631b2df2b9a4c42de60fb4e0477da2c953/lib/puppet/functions/vault_lookup/lookup.rb#L5-L7 The new param
is being added in a PR, having bothvault_namespace
andvault_cert_role
being strings will causevault_namespace
to maplookup('something/path', 'namespace')
to "namespace" correct? So thevault_cert_role
should change to another more strict datatype?vault_namespace - r
root-expert
06/28/2022, 9:23 AMHello, I got a question to see if my concerns are correct: https://github.com/voxpupuli/puppet-vault_lookup/blob/478f5e631b2df2b9a4c42de60fb4e0477da2c953/lib/puppet/functions/vault_lookup/lookup.rb#L5-L7 The new param
is being added in a PR, having bothvault_namespace
andvault_cert_role
being strings will causevault_namespace
to maplookup('something/path', 'namespace')
to "namespace" correct? So thevault_cert_role
should change to another more strict datatype?vault_namespace - t
TheMeier
06/28/2022, 1:19 PMre systemd timer, if you add a wrapper consider putting in optional additional parameters for timer and service in the templates like it's done here https://github.com/TheMeier/themeier-systemd_cron/blob/master/manifests/init.pp#L79 - t
TheMeier
06/28/2022, 1:19 PMre systemd timer, if you add a wrapper consider putting in optional additional parameters for timer and service in the templates like it's done here https://github.com/TheMeier/themeier-systemd_cron/blob/master/manifests/init.pp#L79 - v
VoxBot
06/28/2022, 1:20 PMZhenech: ewoud: systemd:⏲️:templated - could also roll the whole thing into systemd::timer and make the diffeent combinations of args mutually exclusive. - v
VoxBot
06/28/2022, 1:21 PMfrisbee: I feel that would be a lot more complex in its logic - v
VoxBot
06/28/2022, 1:22 PMfrisbee, I thought about that, and I am torn, so didn't suggest it immediately - v
VoxBot
06/28/2022, 1:23 PMI am not a fan of interfaces that do different things based on different input, but in this case it's actually not even really a diffent thing