https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    afisher++ for the redundant Optional puppet-lint plugin
  • d
    afisher is on the rise! (Karma: 4)
  • v
    finding a few examples in theforeman-* modules now that I'm updating to voxpupuli-test 5 :)
  • v
    yeah, thanks for all the super long diffs :P
  • v
    you're welcome :D
  • v
    redundant optional?
  • v
    Optional[String] $foo = 'bar'
  • v
    it has a default value, thus the "Optional" is redundant
  • v
    ah that, yes
  • v
    brought up a shitload of broken code at $customer :D
  • v
    broken in what way?
  • v
    imho, this isn't useful
    Copy code
    Optional[String] $foo = 'bar'
    You can't pass undef to a class
  • v
    Normal application is this
    Copy code
    Optional[String] $foo = undef
  • v
    that's exactly what the lint plugin yells at you about
    👍 1
  • v
    it's either String $foo = 'bar' or Optional[String] $foo = undef
  • v
    and the lint plugin can't decide which is correct so there's no autofix, but at least it complains about it
  • a
    @bastelfreak Are you using webhook-go yet?
  • v
    had no time yet to set it up for my private infra and all customers are on PE at the moment
  • v
    do we already have a puppet module to configure webhook-go?
  • a
    Don't think so. Just trying to get it going manually at the moment. Seems to run r10k, but even with the 
    verbose
    option set, I can' actually see any output from r10k being logged.
  • a
    ah. I think the command output is returned to the caller, and gitlab times out after 10 seconds whilst this r10k operation took 60s for me (lots of environments). https://github.com/voxpupuli/webhook-go/blob/c03c8fa940255285e7233e7a7067114d0ed4f195/api/module.go#L80
  • a
    ah. I think the command output is returned to the caller, and gitlab times out after 10 seconds whilst this r10k operation took 60s for me (lots of environments). https://github.com/voxpupuli/webhook-go/blob/c03c8fa940255285e7233e7a7067114d0ed4f195/api/module.go#L80
  • a
    From the gitlab docs... "Your endpoint should send its HTTP response as fast as possible. You should aim for sub-second response times in all circumstances."
  • a
    and "If a webhook fails repeatedly, it may be disabled automatically."
  • v
    you could implement a timeout where it returns HTTP 202 after x seconds
  • a
    Interestingly, it's already configured to respond with a 202, but after the work has actually been done, and with the command output.
  • v
    that's an interesting approach
  • a
    Doesn't seem to be what 202 is for.
  • v
    indeed, I'd expect it to return HTTP 200 after all the work or 202 if it hasn't completed yet
  • a
    Not sure if it's ever going to be worth trying to give r10k enough time to complete if we're supposed to aim for sub-second responses.
1...858687...648Latest