Hey, thanks for the review! This has been killing me :-/

yes, this is the nasty stuff that is a pain to debug :(

ewoud: I already applied the suggested code changes. Sorry about missing those in my cleanup run-through.

ewoud: Does this get the go ahead or is it back on hold? Sorry to be a bother, just trying to plan on whether or not we're going to have to fork :-(. Alternatively, I could set the default to

false

and flag it where I know that things break in our code.

tvaughan: I'll try to take a look after this game

ewoud: No problem. Honestly, if you're up for getting it through with me on Monday, that would work just fine. Again, really appreciate the help.

tvaughan: I approved it; not sure if you want a last approval from afisher or just merge it

I'm good with one good review. Really do appreciate it and sorry for all the bother

no worries, we've all been in the situation where something bugs you and holds up your work

thanks for working through all my comments :)

Sure thing!

can I get a review for https://github.com/voxpupuli/puppet-r10k/pull/576 and https://github.com/voxpupuli/puppet-r10k/pull/577 ? both together will turn CI green again

I've defined a server and a location in the nginx module and also enabled SSL, module builds the nginx config file almost exaclty as I expect. One part I've not understood is when I define the location it only puts the location in the non-ssl site, rather than in both the ssl and non-ssl 'server' - I'm trying to work out what in the module decides where to put the location data

for example https://gist.github.com/ - that's my hiera and nginx output, if you look at the non-ssl definition, it has a location for / and /air, but the ssl site only has a location of /

if you look at the hiera I've defined the /air location to the server www.oldnewbridgehill.co.uk site so why would this not be in the SSL definition too ?

I can't find the code block that would decide this

your gist link is missing a part :)

quality start to the day

sorry

and for the location defined resource, it has params to configure if you want it in ssl or not

then I'm being dumb, as the location just look like the same has (thereabouts) as the server hash,

so I've missed those params then, let me hav ea look

ahhh so you need to set it outside the actual location hash params

ok, thank you, let me take a look

just as an aside, this module is a masterpiece it's huge in terms of the scope for configuration

I can't imagine how this module was even designed

nobody knows!