https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    pre-existing condition?
  • b
    ✅ 1
    👍 1
  • b
  • v
    hmm, repo list is checked twice, for some reasons, I updated two places now
  • v
    still fails due to
    Copy code
    Error: Lint/RedundantCopDisableDirective: Unnecessary disabling of `RSpec/RepeatedExample`.
  • b
    he
  • b
    mhm
  • b
    I think that check passed on master
  • b
    did you do a git fetch before rebasing?
  • s
    This message was deleted.
    b
    v
    • 3
    • 5
  • b
    interesting
  • b
    let me check again
  • s
    This message was deleted.
    v
    d
    d
    • 4
    • 14
  • d
    Good afternoon - Is there someone who can merge this PR? We are facing this issue in our production environment - https://github.com/voxpupuli/puppet-kmod/pull/81
  • v
    same in 
    /etc/puppetlabs/code/environments/your_test/modules/kmod/
    should not be 
    lib
    directory
  • v
  • v
    <bastelfreak> "can I get a review for https://..." <- ✅
  • v
    I see it merged, but no release yet?
  • v
    A release will happen after a tag is pushed to the repo
    👍 1
  • p
    Hi, some modules in voxpopuli repo are not converted in pdk. Is there any reason to not doing it ?
  • v
    voxpupuli doesn't use PDK, it has its own modulesync configuration (which keeps all of their packages in line with each other)
  • r
    Does archive#469 make sense to anyone but me?
  • r
    Does archive#469 make sense to anyone but me?
  • v
    I agree, probably copy&paste from previous section
  • r
    If so, the copy&paste function is faulty, as it somehow erroneously deleted the 
    /bin
    suffix from the 
    creates
    attribute.
  • r
    I started looking at the docs trying to determine, if there isn't a 
    creates
    attribute, and the 
    cleanup
    attribute is set to 
    true
    , does the archive file get downloaded on every run? Or does it somehow "remember" that it previously succeeded?
  • v
    also, file resource is never defined
  • v
    in my experience, it downloads file if it doesn't present locally, so I am keeping them all inn /opt/staging
  • r
    So basically if the 
    creates
    attribute is missing, then the 
    cleanup
    attribute should be set to 
    false
    .
  • r
    Because leaving 
    cleanup
    at the default 
    true
    will result in the archive being re-downloaded and re-extracted on every Puppet run.
1...789...648Latest