https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    https://github.com/voxpupuli/puppet-catalog-diff/blob/master/lib/puppet/catalog-diff/differ.rb#L8-L11 looks like those three are already considered helper classes. maybe we should add a forth one
  • v
    yeah, a fourth one sounds right
  • v
    goes hacking
  • v
    (but please write it in ruby, not forth :P - https://en.wikipedia.org/wiki/Forth_(programming_language) )
  • v
    w:D
  • v
    a bit annoying that the test environment where I can run this is kinda air-gapped and I need to send patchs via email back and forth...
  • v
    git send-email /me runs
  • v
    :D
  • v
    now back to my ansible madness
  • v
    :(
  • v
    I can replace that with Puppet for you
  • v
  • v
    :P
  • v
    :D
  • v
  • v
    LGTM minus the typo :)
  • v
    fixed that
  • v
    include_system_store: true
    - is that intentional? I'd expect you already have all trusted certs loaded via 
    cacerts = x509.load_cacerts_from_pem(…)
    ?
  • v
    anyways, I have no setup to test this (heck, I don't even have one PuppetDB…) but the code reads correct otherwise
  • v
    (not sure this should be sufficient for an "official" ack?)
  • v
    I set that as a workaround because it will load the official ca-bundle from the puppet-agent. that could be useful for people not providing a complete CA chain in the pem file / the wrong CA
  • v
    and the benefit is that if your puppetdb has a cert from an official CA, puppet catalog diff can now connect out of the box
  • v
  • e
    Hello! I created the PR https://github.com/voxpupuli/puppet-firewalld/pull/327 What’s next?
  • e
    Hello! I created the PR https://github.com/voxpupuli/puppet-firewalld/pull/327 What’s next?
  • b
    I think someone needs to invest some time into https://github.com/voxpupuli/puppet-firewalld/pull/303 to get CI working again, afterwards your PR should be rebased
  • b
    I think someone needs to invest some time into https://github.com/voxpupuli/puppet-firewalld/pull/303 to get CI working again, afterwards your PR should be rebased
  • b
    (I currently do not have enough spare time)
  • b
    Vox Pupuli office hours starts in 15 minutes!
  • b
    check http://pup.pt/vox-sync-agenda for the zoom link if you want to join or ask your question here on slack or here on irc!
1...767778...648Latest