https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • b

    bastelfreak

    06/09/2022, 2:41 PM
    if someone wants to review some ruby https://github.com/voxpupuli/puppet-catalog-diff/pull/68 🙂
  • b

    bastelfreak

    06/09/2022, 2:41 PM
    if someone wants to review some ruby https://github.com/voxpupuli/puppet-catalog-diff/pull/68 🙂
  • v

    VoxBot

    06/09/2022, 4:00 PM
    https://github.com/puppetlabs/puppetlabs-xinetd/pull/124 is the trivial CLA exemption still a thing? https://github.com/puppetlabs/puppetlabs-xinetd/pull/124 is really trivial and it feels hostile to require signing a CLA for that
  • l

    Lumiere

    06/09/2022, 4:00 PM
    @binford2k ^
  • v

    VoxBot

    06/09/2022, 4:06 PM
    ewoud: unfortunately it's not. The problem with it was that it left the determination of whether a patch is trivial or not up to the engineer reviewing/merging a PR. What you might call trivial may not be what Molly calls trivial and may not be what Tim calls trivial, etc. And many engineers aren't comfortable making decisions like that in the first place, which means that a lot of simple PRs just didn't get merged.
  • v

    VoxBot

    06/09/2022, 4:07 PM
    after a lot of discussion with eng and legal, we decided to remove that. If a patch really is trivial but the author doesn't want to sign the CLA, then someone can easily reimplement the same fix and credit the submitter with reporting the issue.
  • v

    VoxBot

    06/09/2022, 4:41 PM
    it makes sense that you want to remove ambiguity - in this case it is really really trivial, but luckily the CLA has been signed so that removes all complexities
  • v

    VoxBot

    06/09/2022, 5:03 PM
    bleh, looks like https://github.com/kindredgroup/puppet-forge-server is unmaintained: https://github.com/kindredgroup/puppet-forge-server/pull/79#issuecomment-558533571
  • v

    VoxBot

    06/09/2022, 5:04 PM
    is there a different implementation people use? my use case now is just getting the cucumber tests of librarian-puppet to run
  • t

    tvaughan

    06/09/2022, 5:05 PM
    Git repos FTW
  • v

    VoxBot

    06/09/2022, 5:06 PM
    well, one feature is to run with a private forge
  • v

    VoxBot

    06/09/2022, 5:07 PM
    but I guess a local git clone with patches can work for now
  • v

    VoxBot

    06/09/2022, 5:07 PM
    I mean, it just needs to connect to localhost port 80, perhaps I can even stub that somehow :P
  • v

    VoxBot

    06/09/2022, 5:09 PM
    ewoud: https://github.com/parship/puppet-forge_server/pull/2 we used that at a customer I think
  • v

    VoxBot

    06/09/2022, 5:16 PM
    bastelfreak: https://github.com/kindredgroup/puppet-forge-server/issues/78 is what I run into now
  • v

    VoxBot

    06/09/2022, 5:16 PM
    note that I'm just talking about the gem here, not even a puppet module to manage it
  • v

    VoxBot

    06/09/2022, 5:18 PM
    ah yeah :( customer is enterprise (which just means software as old as I am)
  • v

    VoxBot

    06/09/2022, 5:20 PM
    recently I was at an org where I was a board member during university and while discussing the cash register software (written in house) and that it was started in 2001 one of the current active members mentioned that's older than he is
  • v

    VoxBot

    06/09/2022, 5:22 PM
    for context, back when I was working on it I did a lot of Java 1.4 → 1.5 (or Java 5 as it was later known) conversion which meant adding a lot of generics and other neat features
  • v

    VoxBot

    06/09/2022, 5:22 PM
    moving past Java 1.4 felt great ;)
  • v

    VoxBot

    06/09/2022, 5:23 PM
    that was around 2007 IIRC
  • v

    VoxBot

    06/09/2022, 5:25 PM
    bastelfreak: heads up: it's horribly broken now on current Ruby and current gems ;)
  • v

    VoxBot

    06/09/2022, 5:25 PM
    Error reading from module archive modules/puppetlabs-inifile-5.3.0.tar.gz: wrong number of arguments (given 2, expected 1)
  • v

    VoxBot

    06/09/2022, 5:28 PM
    nice
  • v

    VoxBot

    06/09/2022, 5:29 PM
    I love artifactory as mirror/proxy. but thata some heavy and expensive java :(
  • v

    VoxBot

    06/09/2022, 5:32 PM
    yes, kind of heavy just for running CI
  • v

    VoxBot

    06/09/2022, 5:33 PM
    ok, allowing json 2.x instead of ~> 1.8 helps and I can at least move on
  • v

    VoxBot

    06/09/2022, 5:36 PM
    doesnt pulp/katello would work as well?
  • v

    VoxBot

    06/09/2022, 5:36 PM
    but I thinj they are also heavy
  • v

    VoxBot

    06/09/2022, 5:37 PM
    yep
1...636465...648Latest