# voxpupuli
- b
bastelfreak
10/30/2024, 9:40 AMfine by me - y
Yury Bushmelev
10/30/2024, 9:40 AMactually that will open can of worms^Wcascading changes pending.. but anyway :) - b
bastelfreak
10/30/2024, 9:41 AMand we should clean up metadata.json and the data/ dir - y
Yury Bushmelev
10/30/2024, 9:41 AMyeah.. I'll work on it tomorrow maybe.. luckily, this fits my current task on my job 😄 - v
VoxBot
10/30/2024, 9:43 AMcan I get a review for https://github.com/voxpupuli/puppet-consul/pull/678 - v
VoxBot
10/30/2024, 9:54 AMFYI: there's about a day left until cfgmgmtcamp cfp closes - v
VoxBot
10/30/2024, 9:54 AMin good old tradtion I've to submit after the deadline! - v
VoxBot
10/30/2024, 9:55 AMewoud: while you're here! I want to merge https://github.com/voxpupuli/beaker_puppet_helpers/pull/49 - v
VoxBot
10/30/2024, 9:56 AMbastelfreak: I'd still like to see something smarter to determine the destination - v
VoxBot
10/30/2024, 9:56 AMbut I wonder what's a good API - v
VoxBot
10/30/2024, 9:57 AMperhaps: def install_puppet_modules_via_rsync(hosts, source: 'spec/fixtures/modules/', destination_path: nil, environment: nil) - v
VoxBot
10/30/2024, 9:57 AMand then require either a destination path or an environment? - v
VoxBot
10/30/2024, 10:12 AMokay, I can add that - v
VoxBot
10/30/2024, 10:12 AMcan I get a review for https://github.com/voxpupuli/puppet-consul/pull/679 and https://github.com/voxpupuli/beaker_puppet_helpers/pull/53 - v
VoxBot
10/30/2024, 10:22 AM - v
VoxBot
10/30/2024, 11:52 AMcan I get a review for https://github.com/voxpupuli/puppet-consul/pull/681 - v
VoxBot
10/30/2024, 12:04 PMewoud: Zhenech https://github.com/theforeman/puppet-puppetserver_foreman/pull/51 is that something one of you could review and merge? - v
VoxBot
10/30/2024, 12:59 PMbastelfreak: rather busy with preparing Foreman 3.13 branching right now so I'm focusing on getting releases out - v
VoxBot
10/30/2024, 1:00 PMoki - v
VoxBot
10/30/2024, 1:00 PMshould have finished that last week - v
VoxBot
10/30/2024, 1:00 PM:D - y
Yury Bushmelev
10/30/2024, 2:57 PMMerged my PR.. Shall we release the systemd module before dropping EOL OSes? - b
bastelfreak
10/30/2024, 2:57 PMare there already breaking changes merged? - y
Yury Bushmelev
10/30/2024, 2:58 PMso those who still on RHEL 7 will be able to use latest features 🙂 - y
Yury Bushmelev
10/30/2024, 2:58 PMhm.. my PR is non-breaking (I believe at least) - y
Yury Bushmelev
10/30/2024, 2:59 PMwell.. 7.1.0 is quite old according to git history - y
Yury Bushmelev
10/30/2024, 3:00 PMthere were bunch of modulesyncs after.. not sure how breaking it was - b
bastelfreak
10/30/2024, 3:01 PMusually not at all - b
bastelfreak
10/30/2024, 3:01 PMyou can just generate a changelog and see if any PR had a backwards-incompatible label - y
Yury Bushmelev
10/30/2024, 3:02 PMok, I’ll check it tomorrow morning, while nobody is here 😄 So I’ll write another wall of text for you to read in the morning