https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    okay, I can hack that
  • v
    no, we don't have such a thing now
  • v
    ah nice, works
  • v
    https://github.com/theforeman/puppet-foreman_proxy/pull/848 this is indeed enough to get it working on PE, neat
  • v
  • v
    pe_version.rb is a mess, in my opinion. the one in PE doesn't match one in stdlib and which one you use is totally random
  • b
    I know. I would have provided a PR for this, but the repo is private. I would have provided a patch, but the license doesn't allow it
  • b
    Reason 24868 why you shouldn't use PE
  • v
    imho PE should rename it's file and set higher priority
  • b
    IMO PE should rely on stdlib
    💯 1
  • b
    And I've many more opinions on PE 😄
  • v
    seems they prefer customized copies for some reasons. pe_nginx, pe_postgresql, pe_inifile and so on
  • b
  • v
    I use 'default_production'
  • v
  • y
    I see many our repos has .vscode/extensions.json with outdated (dead) 
    rebornix.Ruby
    extension.. I'd either 1) drop the .vscode directory completely from our repos; 2) substitute the extension with 
    Shopify.ruby-lsp
    (I'm using it for about a year now). Any comments on this?
  • y
    In any case this directory should be modulesynced (either to delete it or to make it consistent across the modules) I'd say.
  • y
    (/IMHO)
  • k
    I’d lean toward deleting 
    .vscode
    so that we don’t have to maintain it
    ➕ 1
  • y
    it'd be nice if puppet-systemd would manage files entirely, not with 
    ini_settings
    .. but I'm sure there are users who will complain because there is another software changing part of their files..
  • d
  • v
    yeah, I too don't think we should carry editor-specific things in our repos
  • y
    I'll raise a PR to drop it from systemd module at least then
  • t
    how did it get there if it is not in modulesync_configs?
  • v
    via pdk in the past I guess
  • v
    so please raise a PR against moduelsync_config to delete the files
  • v
    Yury: problem with managing the whole file is that the systemd versions across operating systems varies a lot and, at least older, versions don't unknown keys in their config files. I considered managing whole files, but that would mean we need to have a mapping of options<>OS
  • y
    Well.. that makes sense, though after seeing sudo module with all the templates I'm ok with that 😄
  • y
    it's possible to keep that under the same template but someone will need to update conditions from the documentation
  • y
    I tried to find a way how we can generate types at least.. and found none.. systemd is very specific piece of software
1...605606607...648Latest