https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • t
    OK, got the go ahead, doing the things
  • t
  • s
    This message was deleted.
    t
    • 2
    • 2
  • t
  • t
  • v
    o/ Hey friends! I am back from holidays and spent some time this week to process all the mail that accumulated while away. Good news: I am reaching the end.
  • v
    While on vacation I sent a quick message about the bacula module from zleslie which I have been using for years, and it is about te be transferred to me so that I can transfer it to vox
  • v
    I think it was something we talk about with bastelfreak: vox currently has a bacula module which is not very up-to-date / maintained / usable
  • v
    smortex: o/
  • v
  • v
  • m
    I'm just looking on the voxpupuli website about guidelines for merge requests, I'd like to submit a really basic one and want to make sure I do all the steps correctly, eg: do I need to raise an issue first, does the commit message need to include the issue ref etc etc
  • m
    never mind, found the doc on github
  • b
    the modules usually have a .github/CONTRIBUTING.md which explaina it. tl;dr just raise the PR :)
  • m
    exactly where I found it
  • m
    still managed to screw up the test, I'll cancel request, I didn't fully grasp not referencing top scope params
  • m
    why is it bad to reference a top scope parameter from a class
  • b
    using topscope is bas because you dont know if its a class param a fact or a real topscope variable
  • b
    and the lint_fix rake task is good in automatically fixing those issues
  • m
    would it not be simpler to just not have class topscope variables not called the same as facts ?
  • m
    (I see what you mean in this specific situation as I'm referencing something called 'version' which could be anything)
  • m
    I'm reading the style guide at the moment and I can't see anything that guides how to reference a top scope parameter correctly inline with vox standards, I get that ::param won't cut it and I see why based on your comment, but is still acceptable to do class::param ? or is that covered somewhere else outside of the style guide
  • m
    (think I found what I needed)
  • b
    $class::param
    is usually the way to go, and 
    $facts
    or 
    fact()
    for facts
  • l
    the problem is you never know what custom facts will exist
  • p
    I'm trying to get https://github.com/voxpupuli/puppet-logrotate/pull/195 into shape, but I've no idea why those tests are failing.... any hints?
  • p
    I'm trying to get https://github.com/voxpupuli/puppet-logrotate/pull/195 into shape, but I've no idea why those tests are failing.... any hints?
  • h
    it looks like you should be able to do some of the tests listed in 
    .github/workflow/ci.yaml
    like 
    bundle exec rake validate lint check
    and 
    bundle exec rake rubocop
    and 
    bundle exec rake parallel_spec
    so that you can see what it is erroring on
  • p
    Copy code
    Running RuboCop...
wrong number of arguments (given 5, expected 1)
/usr/share/ruby/psych.rb:323:in `safe_load'
  • p
    Copy code
    bundle exec rake validate lint check 
---> syntax:manifests
---> syntax:templates
---> syntax:hiera:yaml
fatal: ls-files -i must be used with either -o or -c
1...585960...648Latest