# voxpupuli
- b
bastelfreak
11/14/2023, 9:39 PMthey even have a track record if breaking other tools - b
bastelfreak
11/14/2023, 9:39 PMyes, but I dont want to put my ini data into yaml - v
VoxBot
11/14/2023, 9:39 PMAFAIK it's more of a tool to describe either systemd-networkd or NetworkManager - j
jhoblitt
11/14/2023, 9:40 PMthey have such a great track record: mir, bzr, snapd, upstart...phoenix sweat 1 - h
hbui
11/14/2023, 9:43 PMCan I get a review of https://github.com/voxpupuli/facterdb/pull/290 ? - j
jhoblitt
11/14/2023, 9:43 PM!!! - h
hbui
11/14/2023, 9:44 PMturns out adding in 18 json files each with 450-600 lines adds up, who knew? - j
jhoblitt
11/14/2023, 9:47 PMtried to add more work for ya 😉 - b
bastelfreak
11/14/2023, 9:48 PMthat diff really renders shitty on a phone :D - h
hbui
11/14/2023, 9:48 PMI blame the table - v
VoxBot
11/14/2023, 9:51 PMI should revisit https://github.com/voxpupuli/facterdb/pull/262 too - v
VoxBot
11/14/2023, 9:51 PMand I've been debating a major version bump which drops Facter < 3 facts at least - h
hbui
11/14/2023, 9:53 PMI did wonder about creating a different facts directory for old data (can't name it legacy though) and then massively simplifying the get_facts.sh script - v
VoxBot
11/14/2023, 9:53 PMewoud: yes - h
hbui
11/14/2023, 9:53 PMdump all the old bits there as a reference - v
VoxBot
11/14/2023, 9:54 PMor just git rm it? - v
VoxBot
11/14/2023, 9:54 PMif you need the old facts you can use an older facterdb version - h
hbui
11/14/2023, 9:57 PMthere's also a need to alter get_facts.sh not to use legacy facts 🙂💯 1 - b
bastelfreak
11/14/2023, 9:58 PMI am happy to review PRs :) - h
hbui
11/14/2023, 9:58 PMlol - h
hbui
11/14/2023, 9:59 PMI'll keep that in mind - v
VoxBot
11/14/2023, 10:00 PMthere was some debate about that and it's tricky - v
VoxBot
11/14/2023, 10:00 PMbecause the same Facter version could be used with both Puppet 7 & 8 - h
hbui
11/14/2023, 10:01 PMbecause of the aio_agent_version? - v
VoxBot
11/14/2023, 10:02 PMno, Facter 4.4 could run in Puppet 7 with legacy facts and Facter 4.5 could run in Puppet 8 without legacy facts - v
VoxBot
11/14/2023, 10:03 PMwell, this is a new error from quay: https://github.com/theforeman/puppet-candlepin/actions/runs/6869985197/job/18683955418?pr=247 - h
hbui
11/14/2023, 10:03 PMI suspect my team will give up legacy facts only when they are truly gone - v
VoxBot
11/14/2023, 10:04 PMPuppet 8 forces you to? - v
VoxBot
11/14/2023, 10:04 PMewoud: do you have an internal slack for it? :D - h
hbui
11/14/2023, 10:04 PMno