https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    08/02/2023, 8:57 PM
    we create a tag locally, push that, github create a release
  • v

    VoxBot

    08/02/2023, 8:58 PM
    the pushed tag triggers the github action
  • v

    VoxBot

    08/02/2023, 8:58 PM
    Ah, yes!
  • v

    VoxBot

    08/02/2023, 8:58 PM
    but it determines the version for the release from the gemspec, not from the name of the pushed tag
  • v

    VoxBot

    08/02/2023, 8:59 PM
    So yes, we used the wrong version in metadata, reviewers did not notice (so good job smortex too), and the release used the actual information not the tag name
  • v

    VoxBot

    08/02/2023, 9:02 PM
    https://github.com/voxpupuli/modulesync/pull/274/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR9 I added a sentence to clarify it
  • v

    VoxBot

    08/02/2023, 9:03 PM
    ^^^ 2.7.0 not 2.8.0
  • v

    VoxBot

    08/02/2023, 9:03 PM
    now it's even more confusing because the changelog uses the git tags
  • v

    VoxBot

    08/02/2023, 9:04 PM
    Yeah!
  • v

    VoxBot

    08/02/2023, 9:04 PM
    https://semver.org/#what-do-i-do-if-i-accidentally-release-a-backward-incompatible-change-as-a-minor-version
  • v

    VoxBot

    08/02/2023, 9:04 PM
    you can yank gems
  • v

    VoxBot

    08/02/2023, 9:05 PM
    Should we do releases to attempt to fix all the things or is it just one way to shoot more bullets in our feets?
  • v

    VoxBot

    08/02/2023, 9:05 PM
    updated the sentence
  • v

    VoxBot

    08/02/2023, 9:05 PM
    https://guides.rubygems.org/removing-a-published-gem/
  • v

    VoxBot

    08/02/2023, 9:05 PM
    Nice
  • v

    VoxBot

    08/02/2023, 9:05 PM
    I don't think that important to fix it. it happend two months ago and nobody complained
  • v

    VoxBot

    08/02/2023, 9:06 PM
    We can remove the tag and re-tag a 3.0.0 then ?
  • v

    VoxBot

    08/02/2023, 9:06 PM
    and yanking it might add more confusion
  • v

    VoxBot

    08/02/2023, 9:06 PM
    Yeah :)
  • v

    VoxBot

    08/02/2023, 9:06 PM
    I suggest we just release 3.1.0
  • v

    VoxBot

    08/02/2023, 9:06 PM
    +1
  • v

    VoxBot

    08/02/2023, 9:07 PM
    I am fine with it, ty for the yank link, I was searching for a button on a gem page and there is no UI for it, so I was thinking maybe I made up this feature.
  • v

    VoxBot

    08/02/2023, 9:08 PM
    smortex: remember good old puppet 8 that was released without proper anouncement? that was yanked :D
  • v

    VoxBot

    08/02/2023, 9:08 PM
    The sentense will disapear on the next release, is it a concer?
  • v

    VoxBot

    08/02/2023, 9:08 PM
    no
  • v

    VoxBot

    08/02/2023, 9:08 PM
    I did magic
  • v

    VoxBot

    08/02/2023, 9:08 PM
    https://github.com/voxpupuli/modulesync/issues/275
  • v

    VoxBot

    08/02/2023, 9:08 PM
    that's the source
  • m

    Markus Zilch

    08/02/2023, 9:09 PM
    🪄
  • v

    VoxBot

    08/02/2023, 9:09 PM
    <3
1...568569570...648Latest