https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    06/01/2022, 3:47 PM
    I migut be the first person in years that uses overcommit
  • v

    VoxBot

    06/01/2022, 3:47 PM
    *You might
  • v

    VoxBot

    06/01/2022, 3:47 PM
    I figured it was in the modulesync config so I should use it since I like commit hooks in general
  • v

    VoxBot

    06/01/2022, 3:51 PM
    _uploaded an image: (48KiB) <

    https://libera.ems.host/_matrix/media/r0/download/technicalissues.us/blktTSgDLVLBjDgUzUyMcvaq/image.pngβ–Ύ

    >_
  • v

    VoxBot

    06/01/2022, 3:51 PM
    Seems that weird git line is coming from elsewhere
  • v

    VoxBot

    06/01/2022, 3:51 PM
    Also seems the failure is coming from overcommit (I think)
  • b

    bastelfreak

    06/02/2022, 3:40 PM
    can I get a review for https://github.com/voxpupuli/facterdb/pull/250
  • b

    bastelfreak

    06/02/2022, 3:40 PM
    can I get a review for https://github.com/voxpupuli/facterdb/pull/250
  • b

    bastelfreak

    06/02/2022, 3:46 PM
    also https://github.com/voxpupuli/puppet-zabbix/pull/822 please πŸ™‚
  • b

    bastelfreak

    06/02/2022, 3:46 PM
    also https://github.com/voxpupuli/puppet-zabbix/pull/822 please πŸ™‚
  • r

    root-expert

    06/02/2022, 3:50 PM
    bastelfreak I wouldn't release it yet
  • r

    root-expert

    06/02/2022, 3:50 PM
    Someone upgrading from any version below 6.0 will render his setup unusable
  • b

    bastelfreak

    06/02/2022, 3:51 PM
    meh
  • r

    root-expert

    06/02/2022, 3:51 PM
    Zabbix changed the database schema and it needs the migration to work properly, I should have converted that PR to draft 😞
  • b

    bastelfreak

    06/02/2022, 3:53 PM
    do you still have the changes in a local branch
  • b

    bastelfreak

    06/02/2022, 3:53 PM
    I could revert it, redo the changelog, release it without the change, you open the PR again as draft
  • r

    root-expert

    06/02/2022, 3:59 PM
    Yes I do have it, could I try to file a new PR fixing this issue real quick, if it doesn't work we can fallback to the plan above
  • b

    bastelfreak

    06/02/2022, 3:59 PM
    okay, sounds good to me
  • r

    root-expert

    06/02/2022, 4:03 PM
    Hmm I might be wrong πŸ˜… https://www.zabbix.com/documentation/current/en/manual/appendix/install/db_primary_keys Seems users must do this manually facepalm I don't think so it's something puppet should handle
  • r

    root-expert

    06/02/2022, 4:04 PM
    Can you fix rubocop on the release PR btw?
  • b

    bastelfreak

    06/02/2022, 4:08 PM
    done
  • b

    bastelfreak

    06/02/2022, 4:09 PM
    so should we revert your change? Or release it as is?
  • r

    root-expert

    06/02/2022, 4:10 PM
    Release it, if someone complains πŸ™ˆ oh well
  • b

    bastelfreak

    06/02/2022, 4:10 PM
    can you review the facterdb PR?
  • v

    VoxBot

    06/02/2022, 4:11 PM
    rubberstamp
  • r

    root-expert

    06/02/2022, 4:12 PM
    xD
  • r

    root-expert

    06/02/2022, 4:12 PM
    I'm too slow
  • v

    VoxBot

    06/02/2022, 4:12 PM
    no, I'm just too fast? :D
  • v

    VoxBot

    06/02/2022, 4:12 PM
    you were looking at the zabbix one
  • s

    Slackbot

    06/02/2022, 5:23 PM
    This message was deleted.
    b
    b
    +2
    • 5
    • 14
1...555657...648Latest