Puppet Community

<https://yum.puppetlabs.com/puppet/el/7/aarch64/index.html> is there a reason 7.25.0 wasn't published?

also, if someone is interested: I'm playing with a script to derive the Ruby testing matrix from the required_ruby_version field in the gemspec: <https://github.com/theforeman/actions/pull/3>

so similar to gha-puppet where you just set the Puppet requirement in metadata.json and CI is updated, you'll just make sure required_ruby_version is correct

playing with creating more actions: <https://github.com/marketplace/actions/derive-ruby-versions> - and I just realized I should have added an example

and <https://github.com/theforeman/actions/pull/3/files> uses that, <https://github.com/ekohl/metadata_json_deps/pull/21/files> is a complete example

I rebased <https://github.com/voxpupuli/rspec-puppet-facts/pull/152> and now it's green

Still no luck? I can have a look tomorrow If have time..

well when i started out there were 60 errors so i’m pleased it’s “just” one now :slightly_smiling_face: but to answer your question: no, i still have not figured the error out.

also thanks in advance!

looking into it.. while setting it up I found Ubuntu 16.04 is unsupported by latest java module.. switched it to 18.04 in metadata.json

you’re including minecraft class which includes minecraft::properties class which creates minecraft::server_setting { ‘server.properties’: }

but if i don’t then i’ll get the error that minecraft::install_dir is an unknown variable

simple workaround is to change the title to any template name from the templates dir

so something like this in the spec-file then?

```        context 'with all parameters set' do
          let(:params) do
            {
              title: 'server.properties'
            }
          end```

no, it’s already in the spec file:

```      let :title do
        'server.properties'
      end```
if i remove the minecraft-class include it complains that minecraft::install_dir is an unknown variable, how does one define those, using a let statement for minecraft::install_dir does not work. any chance there’s a reference or some documentation for writing these tests that i can read? i’ve checked here: <https://voxpupuli.org/docs/> but can only find how to run the tests, not how to write them

Sorry, got other things to do. The “title” should be changed to one not referenced in minecraft::properties class

well.. it doesn’t work, there is another conflict

no worries. all the other templates are referenced by other classes so even if i do change to minecraft_init then the tests will fail because the service class will get a duplicate resource definition. any way to set minecraft::install_dir in the spec file? that would mean that i could drop `include minecraft` which would probably mean that the duplicate resource definition will be gone

yes, this is where I’m coming :slightly_smiling_face:

```# @summary Manage the server properties file
#
# @param content
#   Custom config content
define minecraft::server_setting (
  String $content = template("minecraft/${title}.erb"),
) {
  file { $title :
    ensure  =&gt; file,
    path    =&gt; "${minecraft::install_dir}/${title}",
    content =&gt; $content,
    owner   =&gt; $minecraft::user,
    group   =&gt; $minecraft::group,
    mode    =&gt; '0664',
    require =&gt; User[$minecraft::user],
  }
}```

this way you can override the template in spec file

```# frozen_string_literal: true

require 'spec_helper'

describe 'minecraft::server_setting', type: :define do
  let(:pre_condition) { 'include minecraft' }
  let(:params) do
    {
      content: '# this is a custom test config file',
    }
  end
  let(:title) { 'test' }

  on_supported_os.each do |os, os_facts|
    context "on #{os}" do
      let(:facts) { os_facts }

      it { <http://is_expected.to|is_expected.to> compile.with_all_deps }
    end
  end
end```

```minecraft::server_setting on debian-11-x86_64 is expected to compile into a catalogue without dependency cycles
     Failure/Error: it { <http://is_expected.to|is_expected.to> compile.with_all_deps }
       error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Minecraft::Server_setting[server.properties] is already declared at (file: /Users/user/git/puppet-minecraft/spec/fixtures/modules/minecraft/manifests/properties.pp, line: 6); cannot redeclare (line: 3) (line: 3, column: 1) on node machine.local```
seems like it still doesn’t like including the minecraft class, any way to define minecraft::install_dir in the rspec? am i correct in assuming minecraft in this example is an object and install_dir is a property?

i’ve pasted the code into my files and updated the github repo so that it reflects my local ditto but i cannot get the code to work, i still get the duplicate declaration error for minecraft::server_setting[server.properties]. wonder if it has something to do with me using puppet installed via homebrew. if i run the tests using `bundle exec rake parallel_spec` then it uses ruby 2.6 but `pdk test unit` uses 3.2.2, both give the same errors though.
pdk is crazy slow in comparison though, it takes around a minute to finish testing against the three targets while bundle takes around half of that time

I’ll recheck with your latest repo again today

This is the reason: <https://github.com/Ph0B1uS/puppet-minecraft/blob/convert-to-pdk-module/spec/defines/server_setting_spec.rb#L17>

```➜  puppet-minecraft git:(convert-to-pdk-module) ✗ git diff
diff --git a/spec/defines/server_setting_spec.rb b/spec/defines/server_setting_spec.rb
index 07221c5..63cf895 100644
--- a/spec/defines/server_setting_spec.rb
+++ b/spec/defines/server_setting_spec.rb
@@ -14,9 +14,6 @@ describe 'minecraft::server_setting', type: :define do
   on_supported_os.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
-      let :title do
-        'server.properties'
-      end
 
       it { <http://is_expected.to|is_expected.to> compile.with_all_deps }
     end```

See the `puppet-minecraft` module at <https://forge.puppet.com/puppet/minecraft?src=slack&amp;channel=voxpupuli>

would you look at that, it actually passes all tests now, beautiful! thanks for all the help. any pointers on where to go in order to learn how to write proper modules from scratch including unit tests? are there any books or useful resources?

I’d say learn on examples.. maybe <@U1PC2RAH0> can suggest something though 

puppetlabs-ntp is kind of golden standard 

See the `puppetlabs-ntp` module at <https://forge.puppet.com/puppetlabs/ntp?src=slack&amp;channel=voxpupuli>

<https://www.packtpub.com/product/puppet-8-for-devops-engineers/9781803231709|https://www.packtpub.com/product/puppet-8-for-devops-engineers/9781803231709>

cool, i’ll definitely check the book and aforementioned module out

i’ve been looking for a good class to get certified but can’t really seem to find any, i’m based in sweden, don’t know if that’s the reason why but i find it’s really hard to find good consultants too for some reason, the only help i can find is ansible based and i don’t really fancy the fire and forget approach :slightly_smiling_face:

We also support customers in Sweden :) (we are from Germany)

ping me here or at <mailto:info@betadots.de|info@betadots.de> if you need any puppet training/consultancy

thanks, i will… once i get back from my vacation. believe it or not but for some reason my manager doesn’t really want me to play with minecraft servers when i’m working :slightly_smiling_face:

zhats good practice without breaking prod infra! :D

maybe because we’re an e-commerce company focused on selling clothes and that sort of thing but who knows? :slightly_smiling_face:

let me know when you're back from vacation

will do, i’ll be back early august unless something unexpected happens of course :slightly_smiling_face:

bastelfreak: and I just realized I found another way to shave off a second (3,5 → 2,5): <https://github.com/voxpupuli/rspec-puppet-facts/pull/158>

very hacky, needs work but the concept is simple

if we enhance FacterDB to support returning just string keys then it's easier - may even be better to move the whole string vs symbol keys from FacterDB to rspec-puppet-facts

on the currently released version it took 5,89 seconds to load the same result, for comparison

<https://github.com/voxpupuli/facterdb/pull/282> feels hacky - I wonder if we should accept the JSON.parse(db.to_json) overhead

ewoud: looks like you went down the performance rabbithole :D

and I also noticed JGrep has its own implementation of .dig() and wonder how much of an overhead that is

and I'm doing my best to resist diving in further ;)

Hi there, does anyone know if it's possible to use the <https://github.com/voxpupuli/puppet-catalog_diff|catalog_diff> tool in a local puppet `gem` installation ? The idea is to use 2 already generated catalogs.
The problem is that puppet installed as a gem does not have the `puppetdb` requirement that catalog_diff apparently uses:
```$ bundle exec puppet catalog diff --version
Error: Could not autoload puppet/face/catalog/diff: cannot load such file -- puppet/util/puppetdb
Error: Could not parse application options: Could not autoload puppet/face/catalog/diff: cannot load such file -- puppet/util/puppetdb```

Hey !
Already installed, that and `puppetdb-ruby` just in case :confused:

I had puppetdb-terminus , there's no gem named puppetdb-termini

```$ bundle exec gem list

*** LOCAL GEMS ***

addressable (2.8.4)
aws-eventstream (1.2.0)
aws-partitions (1.790.0)
aws-sdk-core (3.178.0)
aws-sdk-kms (1.71.0)
aws-sdk-secretsmanager (1.73.0)
aws-sigv4 (1.6.0)
backticks (1.0.5)
blockenspiel (0.5.0)
bundler (default: 1.17.3)
CFPropertyList (2.3.6)
coderay (1.1.3)
colored (1.2)
concurrent-ruby (1.1.10)
cri (2.15.6)
deep_merge (1.2.2)
diff-lcs (1.5.0)
facter (4.4.1)
faraday (0.17.6)
faraday_middleware (0.14.0)
fast_gettext (1.1.2)
gettext (3.2.9)
gettext-setup (0.34)
git (1.18.0)
hiera (3.12.0)
hiera-eyaml (2.1.0)
hiera-eyaml-kms (0.2)
highline (1.6.21)
hocon (1.4.0)
httparty (0.21.0)
httpclient (2.8.3)
jmespath (1.6.2)
librarian-puppet (3.0.0)
librarianp (1.1.2)
little-plugger (1.1.4)
locale (2.1.3)
log4r (1.1.10)
logging (2.3.1)
method_source (1.0.0)
mini_mime (1.1.2)
minitar (0.9)
mocha (1.16.1)
multi_json (1.15.0)
multi_xml (0.6.0)
multipart-post (2.3.0)
onceover (3.15.0)
onceover-lookup (0.1.1)
parallel (1.23.0)
parallel_tests (3.12.1)
pathspec (0.2.1)
pry (0.14.1)
pry-nav (1.0.0)
public_suffix (4.0.7)
puppet (6.25.1 universal-darwin)
puppet-lint (2.3.6)
puppet-resource_api (1.8.14)
puppet-syntax (2.4.1)
puppet_forge (2.3.4)
puppetdb-ruby (1.2.0)
puppetdb-terminus (1.0)
puppetlabs_spec_helper (4.0.1)
r10k (3.3.1)
rake (12.3.3)
rchardet (1.8.0)
rspec (3.12.0)
rspec-core (3.12.2)
rspec-expectations (3.12.3)
rspec-mocks (3.12.6)
rspec-puppet (2.12.0)
rspec-support (3.12.1)
rspec_junit_formatter (0.6.0)
rsync (1.0.9)
semantic_puppet (1.0.4)
table_print (1.5.7)
text (1.3.1)
thor (1.2.2)
trollop (2.9.10)
versionomy (0.5.0)```

<https://www.puppet.com/docs/puppetdb/7/connect_puppet_server.html#on-platforms-with-packages>

Yeah ... I was hoping there was a nicer way for ruby gems. Working on an OSX environment with gems the layout seems different to what the instructions suggests and couldn't make it work

you need to follow the 'On platforms without packages' section then

For instance, there's no `puppet/lib/puppet/` in the <http://downloads.puppetlabs.com/puppetdb/puppetdb-6.22.1.tar.gz|puppetdb-6.22.1.tar.gz>

And when installing puppet from `gems` there's no `puppet/lib/ruby/vendor_ruby/puppet` either

Now I get a
```$ bundle exec puppet catalog diff --version
cannot load such file -- puppet/util/command_line```

How can I know which version of puppetdb to download from <http://downloads.puppetlabs.com/puppetdb/> ?
I tried the closest to my puppet version (puppet 6.25 , puppetdb: 6.22) just in case

do you really have to use Puppet 6? That's EoL

In production, I do. On my local setup just for the sake of trying to compare two generated catalogs, I could theoretically upgrade

in theory every puppetdb 6 should be fine, I would stick to latest

Hm ok, will try to setup another puppet env then and see. Thanks for the help :slightly_smiling_face:

<https://github.com/puppetlabs/puppetdb/tree/6.22.1/puppet/lib/puppet>  that's the latest puppetdb 6 lib dir you need

Ok I got it to work by replacing the contents(the `command_line` error was because the whole puppet lib folders were replaced by the ones in puppetdb)

Now, is there a way to compre two local catalogs without actually requiring access to the puppetdb or certs ?
```$ bundle exec puppet catalog diff --certless /tmp/old_catalog.yml /tmp/new_catalog.yml
Notice: Add --debug for realtime output, add --render-as {json,yaml} for parsed output
Error: No such file or directory @ rb_sysopen - /Users/ricardo/.puppetlabs/etc/puppet/ssl/certs/ca.pem
Error: Try 'puppet help catalog diff' for usage```

The catalogs are from masterless puppet installations so we don't have such a setup

I did, but it asks for certificates which I don't have, nor I believe in this case are necessary ? Wondering if such validation could be skipped

does that also happen if you run it without `--certless` ?

Yes :confused:
```bundle exec puppet catalog diff  /tmp/old_catalog.yml /tmp/new_catalog.yml
Error: Failed to parse CA certificates as PEM
Error: Try 'puppet help catalog diff' for usage```
(i _touched_ the cert just in case but no luck &gt;&lt;)

can you run it with --trace --debug and throw the output to <https://gist.github.com/> ?

that's a bug, but I won't have to time fix it immediatly

sure thing, many thanks for the assistance

<https://gist.github.com/sp-ricard-valverde/7509eeb7db9d6f648815e8270d705c9b>

so maybe I got it wrong, but looking at the documentation again ... is it actually possible to diff two local pre-generated catalog files ? I think it's still trying to fetch the nodes

I saw this guide where it talks about <https://dev.to/camptocamp-ops/diffing-puppet-environments-1fno|Local diff> but the official documentation doesn't mention it ?

it's supported. but we refactored the TLS setup and it now always requires local certificates

that's why I asked for the bug report at github :slightly_smiling_face:

Well, do you think if I generate something that looks like a cert it will do the trick ? or will it actually try to validate that ?

any x509 cert + private key should by fine I think

can you try `bundle exec puppet catalog diff  /tmp/old_catalog.yml /tmp/new_catalog.yml --trace --debug`

and the filenames should or needs to be the FQDN of the agent

in your gist it failed at <https://github.com/voxpupuli/puppet-catalog_diff/blob/master/lib/puppet/face/catalog/diff.rb#L211>

but it should have been here: <https://github.com/voxpupuli/puppet-catalog_diff/blob/master/lib/puppet/face/catalog/diff.rb#L202-L205>

my fqdn(according to `bundle exec puppet facts`) is `SPTM-RVALVERDE.Home`, how do you suggest I rename the files ?

but if I want to compare two files for the same node ?

at least the second filename should match the fqdn:  <https://github.com/voxpupuli/puppet-catalog_diff/blob/master/lib/puppet/face/catalog/diff.rb#L204>

Well, now it looks like it got through ! another error though

```$ bundle exec puppet catalog diff --verbose --debug --trace  /tmp/old_catalogs/SPTM-RVALVERDE.Home.yaml 
/tmp/new_catalogs/SPTM-RVALVERDE.Home.yaml

Debug: Runtime environment: puppet_version=6.25.1, ruby_version=2.5.7, run_mode=user, default_encoding=UTF-8
Notice: Add --debug for realtime output, add --render-as {json,yaml} for parsed output
Error: Tried to load unspecified class: Puppet::Resource::Catalog
/Users/ricardo/.rvm/rubies/ruby-2.5.7/lib/ruby/2.5.0/psych/class_loader.rb:97:in `find'
/Users/ricardo/.rvm/rubies/ruby-2.5.7/lib/ruby/2.5.0/psych/class_loader.rb:28:in `load'
/Users/ricardo/.rvm/rubies/ruby-2.5.7/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:391:in `resolve_class'
/Users/ricardo/.rvm/rubies/ruby-2.5.7/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:208:in `visit_Psych_Nodes_Mapping'
/Users/ricardo/.rvm/rubies/ruby-2.5.7/lib/ruby/2.5.0/psych/visitors/visitor.rb:16:in `visit'
/Users/ricardo/.rvm/rubies/ruby-2.5.7/lib/ruby/2.5.0/psych/visitors/visitor.rb:6:in `accept'
/Users/ricardo/.rvm/rubies/ruby-2.5.7/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:32:in `accept'
/Users/ricardo/.rvm/rubies/ruby-2.5.7/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:311:in `visit_Psych_Nodes_Document'
/Users/ricardo/.rvm/rubies/ruby-2.5.7/lib/ruby/2.5.0/psych/visitors/visitor.rb:16:in `visit'
/Users/ricardo/.rvm/rubies/ruby-2.5.7/lib/ruby/2.5.0/psych/visitors/visitor.rb:6:in `accept'
/Users/ricardo/.rvm/rubies/ruby-2.5.7/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:32:in `accept'
/Users/ricardo/.rvm/rubies/ruby-2.5.7/lib/ruby/2.5.0/psych.rb:325:in `safe_load'
/Users/ricardo/.puppetlabs/etc/code/environments/sp_tools_osx/modules/catalog_diff/lib/puppet/catalog-diff/differ.rb:42:in `block in diff'
/Users/ricardo/.puppetlabs/etc/code/environments/sp_tools_osx/modules/catalog_diff/lib/puppet/catalog-diff/differ.rb:36:in `each'
/Users/ricardo/.puppetlabs/etc/code/environments/sp_tools_osx/modules/catalog_diff/lib/puppet/catalog-diff/differ.rb:36:in `diff'
/Users/ricardo/.puppetlabs/etc/code/environments/sp_tools_osx/modules/catalog_diff/lib/puppet/face/catalog/diff.rb:205:in `block (3 levels) in &lt;top (required)&gt;'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/gems/puppet-6.25.1-universal-darwin/lib/puppet/interface/action.rb+eval[wrapper]:261:in `diff'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/gems/puppet-6.25.1-universal-darwin/lib/puppet/application/face_base.rb:254:in `main'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/gems/puppet-6.25.1-universal-darwin/lib/puppet/application.rb:390:in `run_command'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/gems/puppet-6.25.1-universal-darwin/lib/puppet/application.rb:382:in `block in run'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/gems/puppet-6.25.1-universal-darwin/lib/puppet/util.rb:735:in `exit_on_fail'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/gems/puppet-6.25.1-universal-darwin/lib/puppet/application.rb:382:in `run'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/gems/puppet-6.25.1-universal-darwin/lib/puppet/util/command_line.rb:143:in `run'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/gems/puppet-6.25.1-universal-darwin/lib/puppet/util/command_line.rb:77:in `execute'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/gems/puppet-6.25.1-universal-darwin/bin/puppet:5:in `&lt;top (required)&gt;'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/bin/puppet:23:in `load'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/bin/puppet:23:in `&lt;main&gt;'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/bin/ruby_executable_hooks:22:in `eval'
/Users/ricardo/.rvm/gems/ruby-2.5.7@sp-tools-osx/bin/ruby_executable_hooks:22:in `&lt;main&gt;'
Error: Try 'puppet help catalog diff' for usage```

The generated yaml catalogs start with
```--- !ruby/object:Puppet::Resource::Catalog
tags:
- settings
- default
...```

`bundle exec puppet catalog compile --render-as YAML`

Thank you very much for the support :slightly_smiling_face:

can I get a review for <https://github.com/voxpupuli/puppet-catalog_diff/pull/100> ?

JFYI, if you’d like to simplify a `Variant[String, Array[String]]` to just `Array[String]` you can use `Array.new($x, true)`

Thanks to ewoud for the idea (`true` is important, see <https://github.com/puppetlabs/puppet-specifications/blob/master/language/types_values_variables.md#arraynew>)

ah, I don’t need `.new()` even.. can be just `Array($x, true)`

now I can drop all those [$x].flatten finally!

oh, the true argument is a good one - certainly important