Puppet Community

try `SPEC_FACTS_OS='ubuntu-22' bundle exec rake spec`

just found an issue accidentally with `mailhost` resource config in a nginx module.. I guess it’s related to nginx version detection

when first applied it makes a config which is different from what is made on 2nd run

though I’m not sure how to work this around in a better way..

just curious.. can I call `epp()` from an epp template? :slightly_smiling_face:

since that's just a puppet function that should work

I guess so as well.. though I’m not sure if I should follow erb as-is.. maybe it’s better to render them separately and pass as a strings.. need to recheck for the contents

Yury: did you see my comment about the erb2epp script I wrote?

Hi ewoud! Yes, I saw and used it to batch-convert the mailhost templates I’m working on atm :slightly_smiling_face:

great! let me know if we should turn it into a real project

if we can guess somehow where to put the `{` we definitely should

I also like the || → or and &amp;&amp; → and rewrite I could detect

maybe our friends from the CAT team should take it over though :slightly_smiling_face:

this matches their scope really well :slightly_smiling_face:

the problem is that you just have tokens and I wasn't quite sure where to inject the {

perhaps just at the end of the token steam

and you can't use a real parser because the snippets are invalid Ruby

easy fix is to put { in the end of the `if` line

just "if @x" is valid in &lt;% if @x %&gt; but it's not a valid Ruby script

though this can produce wrong result in some cases (multiline conditions)

most of my `if`s have single-line conditions

so you probably need to look for the next newline character, check if it was preceded by \ and then inject it there + append it if you didn't find any

but for a quick evening hacking I was happy with how much I could just do automatically already

yep, tyvm! really helpful as it is already!

maybe I’ll have a look into it later but it’s a bit over my free time limit :slightly_smiling_face:

I stumbled yesterday on legacy stdlib function called from an erb in theforeman/puppet - very easy to miss

See the `theforeman-puppet` module at <https://forge.puppet.com/theforeman/puppet?src=slack&amp;channel=voxpupuli>

bastelfreak: I just rebased <https://github.com/voxpupuli/rspec-puppet-facts/pull/152> and for me on puppet-puppetserver_foreman it was a difference of 10 seconds vs 6 seconds, so I'm quite happy with the result now