https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    why did you replace @sheerun/mutationobserver-shim with @testing-library/user-event?
  • v
    and you want to sync the version with the one in peerDependencies too
  • v
    but otherwise, yes
  • v
    we're not yet sure how to easily test this within our own CI pipeline
  • v
    but that's a different topic
  • v
  • v
    neat
  • v
  • v
    could/should be good now
  • v
    let the jenkins decide
  • v
    jenkins doesn't approve
  • v
    mhm I don't see a real error in the jenkins output
  • v
    you wont, you need to click on the koji link to get useful output
  • v
    but I know what's up
  • v
  • v
    ah
  • v
    should I wait until that's merged or rebase my branch against that?
  • v
    posted a patch to your PR
  • v
    apply that, live happily ever after
  • v
    (or not, you decide)
  • v
    Zhenech++
  • d
    zhenech +1! (Karma: 6)
  • v
    nice, that passed
  • v
    perfect
  • v
    if you'd squash that one fixup into the real commit for foreman_hdm, we can merge
  • v
    done
  • v
    Zhenech: how do I add a new debian package? With scripts/update_package.rb ?
  • v
    mhm or create the dirs by hand
  • v
  • v
    reviewed
1...523524525...647Latest