https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • b
    yeah
  • b
    latest apache release doesn't allow concat v9. but that should not be related
  • b
    https://github.com/voxpupuli/puppet-trusted_ca/pull/53 let's see what happens without versions constraints
  • b
    (if that's even supported by the method)
  • b
    wrong number of arguments (given 2, expected 3)
  • b
    ah well
  • v
    hey psych
  • v
    Zhenech: o/
  • v
    ah it's indeed because of concat
  • v
    because latest apache only allows concat 8.0.1 which only allows stdlib < 9
  • v
    that stdlib change was… something
  • v
    yeah
  • v
  • v
    DROP IT
  • v
  • v
    ACAB
  • v
    (not going to review that dif right now, sorry)
  • v
  • v
    ah that's just safe rubocop autofix
  • s
    This message was deleted.
    d
    b
    • 3
    • 4
  • v
    if it's safe, you don't need a review 🤷 :P
  • v
    oh, GH has chnaged their UI a bit and now has a button for https://github.com/pulls which is nice
  • v
    and it moved from left to right!
  • v
    UI changes :(
  • v
    I'm old. don't change stuff I'm used to
  • v
    I am slightly amazed how non-cursed the diff of https://github.com/theforeman/foreman-ansible-modules/pull/1630/files is
  • v
    (GHA dropped Python 2.7 support, so this now uses the python:2.7 container for those tests, but retains actions/setup-python for all other Pythons)
  • v
    why don't you drop Python 2.7 :O
  • v
    "enterprise" :D
  • v
    :(
1...518519520...643Latest