https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    bastelfreak: can I get a re-review on that puppet-r10k PR
  • v
    wich one?
  • v
    Oh, I thought you already approved it and merged PR 590. Probably should set our PRs to dismiss reviews on changes?
  • v
    I might be able to collect the above (plugin reserved memory) with a custom type like concat does…
  • v
  • v
    .
  • v
    Zhenech++
  • d
    zhenech is on the rise! (Karma: 2)
  • v
    bastelfreak: Should I get a major release ready for r10k, or do we want to get the stdlib stuff cleaned up first and release that as part of the major release?
  • v
    I think we can already do a release
  • v
  • v
  • a
  • a
    Should be ok now. I've run the tests (locally) against the shim instead of just the namespaced version.
  • v
    oh :D
  • a
    It was only eyeball compiled before!
  • v
  • v
    use stdlib::to_toml instead of toml gem
  • a
    @smortex Evening!
  • s
    @Alex Fisher hey đź‘‹
  • a
    I had a thought...
  • a
    Are there any other functions that may have subtly changed behaviour when migration to APIv4??
  • a
    Probably need to check ensure_resource and ensure_resources...
  • a
    oh, my mistake, that hasn't happened yet!
  • s
    you mean when namspacing? I clearly relied on the test suite to catch regression and did not experienced one with the modules where I did some testing, but clearly ensure_package / ensure_resources being the ugliesh pattern I know I avoid them so not seen the problem you opened a PR for :-P
  • a
  • s
    Ah, ensure_resources only exist as a Puppet 3 function, so no regression for it because it has not been namespaced
  • a
    or more importantly not changed api
  • a
    and I think it's only an issue when the function is calling another function. At that point it needs to pass scope on.
  • a
1...499500501...642Latest