# voxpupuli
- v
VoxBot
05/31/2023, 2:06 PMStill need to add acceptance tests, but everything else should be there - v
VoxBot
05/31/2023, 2:11 PMdhollinger: looks good to me - v
VoxBot
05/31/2023, 2:12 PMbastelfreak: I did have to pin the stdlib module for testing since the latest releases breaks a bunch of tests in the r10k module - v
VoxBot
05/31/2023, 2:25 PMah yeah - v
VoxBot
05/31/2023, 2:45 PMDoes anyone remember if there is a way limit beaker-rspec tests based on certain facts? - v
VoxBot
05/31/2023, 2:48 PMAlso, need to update the data types in the go program for this: https://github.com/voxpupuli/webhook-go/pull/73 - v
VoxBot
05/31/2023, 3:03 PMbastelfreak ewoud afisher binford2k and anyone else - could I get a review ^ - v
voxel
05/31/2023, 7:33 PM@bastelfreak I fixed the module tests: https://github.com/voxpupuli/puppet-check_mk/pull/51 - s
Slackbot
05/31/2023, 9:07 PMThis message was deleted.v- 2
- 2
- v
VoxBot
06/01/2023, 8:29 AMWhen I have a
and that includes a "Plugin[$name] ~> Class['something']", is it guaranteed that defined(Plugin['the name']) is true when called inside the something class?define plugin() - v
VoxBot
06/01/2023, 8:30 AMI haven't tested it, but I would assume so - v
VoxBot
06/01/2023, 8:31 AMbut defined() is always ugly - v
VoxBot
06/01/2023, 8:32 AMyes, yes it is - v
VoxBot
06/01/2023, 8:35 AMthe problem I am trying to solve is: - v
VoxBot
06/01/2023, 8:35 AMin theforeman/foreman we have a formula how many puma workers we want to deploy, based on the CPU/ram of the machine - d
Dr Bunsen Honeydew
06/01/2023, 8:35 AMSee the
module at https://forge.puppet.com/theforeman/foreman?src=slack&channel=voxpupulitheforeman-foreman - v
VoxBot
06/01/2023, 8:36 AMand it has a "reservation" for other services running on the box - v
VoxBot
06/01/2023, 8:36 AMbut that reservation, today, is static - v
VoxBot
06/01/2023, 8:37 AMyet the deployments look very differently, especially if you compare a plain foreman to a foreman+katello deployment that pulls in pulpcore and candlepin services (which are hungry too) - v
VoxBot
06/01/2023, 8:37 AM(but you also could apply the thought to foreman with and without a puppetserver) - v
VoxBot
06/01/2023, 8:58 AMnarf, if I only could do <| Plugin |>.each… - m
Marty Ewings
06/01/2023, 9:46 AMthis good for merge? https://github.com/voxpupuli/puppet-telegraf/pull/206 - v
VoxBot
06/01/2023, 9:50 AM. - b
bastelfreak
06/01/2023, 9:51 AM@Marty Ewings is it possible that telegraf::archive_install_dir doesn't contain the version and you cannot do telegraf upgrades now? - b
bastelfreak
06/01/2023, 9:52 AMan acceptance test would help here. we do that a lot in the prometheus module. install an older version and then try to upgrade it - m
Marty Ewings
06/01/2023, 9:58 AMits possible ill check, our acceptance test runs Installs tho https://github.com/puppetlabs/puppet_operational_dashboards/actions/runs/5073262295/jobs/9112094394 - m
Marty Ewings
06/01/2023, 9:59 AMCopy codeNotice: /Stage[main]/Telegraf::Install/Archive[/tmp/telegraf.tar.gz]/ensure: download archive from <https://dl.influxdata.com/telegraf/releases/telegraf-1.25.3_linux_amd64.tar.gz> to /tmp/telegraf.tar.gz and extracted in /opt/telegraf with cleanup - m
Marty Ewings
06/01/2023, 9:59 AMand its downloading it every time - m
Marty Ewings
06/01/2023, 9:59 AMFailure/Error: idempotent_apply(pp) - b
bastelfreak
06/01/2023, 10:00 AMwould be good to have a test for that as well in the telegraf module đŸ˜„