# voxpupuli
- y
Yury Bushmelev
05/30/2023, 11:41 AMI’d git grep beaker and those helpers around.. - y
Yury Bushmelev
05/30/2023, 11:44 AMon a side note while checking your PR above.. I don’t like beaker acceptance tests here aren’t rspec-based (is it minitest?) asserts are nice but I’d prefer unit tests and acceptance tests to have the same.. “language” - y
Yury Bushmelev
05/30/2023, 11:44 AMjust random thoughts.. - b
bastelfreak
05/30/2023, 11:45 AMI totally agree - b
bastelfreak
05/30/2023, 11:45 AMand yes, it's minitest - y
Yury Bushmelev
05/30/2023, 11:46 AMwell.. maybe one day someone will rewrite it to be RSpec-based 🙂 - y
Yury Bushmelev
05/30/2023, 11:48 AM@bastelfreaklib/beaker/host/unix/exec.rb - y
Yury Bushmelev
05/30/2023, 11:48 AMadd_env_var() - y
Yury Bushmelev
05/30/2023, 11:49 AMcheck this function, I believe it is called from some higher levels to add the PATH - y
Yury Bushmelev
05/30/2023, 11:49 AMCopy code# @example # host.add_env_var('PATH', '/usr/bin:PATH') - y
Yury Bushmelev
05/30/2023, 11:50 AMyeah, just in the same filessh_set_user_environment(env) - v
VoxBot
05/30/2023, 11:51 AM - v
VoxBot
05/30/2023, 11:51 AMI never dug into why on Debian that's the case, but in my testing it was needed - y
Yury Bushmelev
05/30/2023, 12:01 PMI think @bastelfreak was asking about this: https://github.com/voxpupuli/beaker/blob/master/lib/beaker/host/unix/exec.rb#L397 - y
Yury Bushmelev
05/30/2023, 12:02 PMJust another random note.. as I see beaker is doing a lot of single command calls in multiple places.. I’d say we may try to merge it to be a single script instead - v
VoxBot
05/30/2023, 12:03 PMewoud: it's a noninteractive shell and /etc/profile.d/ is only used in interactive shells. so I'm wondering why it's not required on EL - y
Yury Bushmelev
05/30/2023, 12:03 PMthat might speedup things.. and the speedup might be even visible - v
VoxBot
05/30/2023, 12:04 PMmaybe EL always reads /etc/profile.d/ - v
VoxBot
05/30/2023, 12:07 PMRe https://github.com/voxpupuli/voxpupuli-acceptance/pull/57 I will update the readme in a new PR, to match the upper case env names - v
VoxBot
05/30/2023, 12:10 PMbastelfreak: well yes, exactly - why is it on Debian but not on EL - v
VoxBot
05/30/2023, 12:11 PMyeah. but it would not hurt to always change PATH I think - v
VoxBot
05/30/2023, 12:11 PMhttps://github.com/voxpupuli/voxpupuli-acceptance/pull/58 README.md cleanup - y
Yury Bushmelev
05/30/2023, 12:14 PMso I can use all-upper-case env vars, right? because I was always trying to follow the docs.. and as I see it was the same in the code.. is ENV case-insensitive? - y
Yury Bushmelev
05/30/2023, 12:16 PMI’d make ENV[] references in code uppercase as well if so - v
VoxBot
05/30/2023, 12:19 PMoh good point - v
VoxBot
05/30/2023, 12:20 PMmhm sometimes I manipulate a merge commit and git... does not like it - v
VoxBot
05/30/2023, 12:30 PM - v
VoxBot
05/30/2023, 12:43 PMhttps://github.com/voxpupuli/voxpupuli-acceptance/pull/59 and the switch within the code to upper case vars - v
VoxBot
05/30/2023, 12:48 PMinteresting, rspec isn't a huge fan of this change - y
Yury Bushmelev
05/30/2023, 12:58 PMI have concern about changing case as ppl might use it in their setups.. so I agree with ewoud that maybe we should 1) either check both uppercase and mixed case -or- 2) release a major version with the change and state it explicitly in the changelog