looking at your code I'm not sure I would agree with providing the dnf modules via facts and validating them

because if you enable a yumrepo with modularity then the fact will only show up (correctly) on the next run

https://github.com/EmersonPrado/dnf/blob/41d5ec07aecac3d227d061070c5642fa7fb1cdfe/lib/puppet/type/dnf_module.rb#L15 that is

similar, I'd suggest to call dnf instead of using facts here: https://github.com/EmersonPrado/dnf/blob/41d5ec07aecac3d227d061070c5642fa7fb1cdfe/lib/puppet/provider/dnf_module/dnf_module.rb#L7-L10

note you can write that more efficient as Facter['dnf_modules'].value[module_name].any? { |k, v| k.include?(profile_name) }

what you can also do is implement prefetch to already load enabled modules

I kinda kept myself away of calling

dnf module

inside those methods because this command is quite costly, and would run more than once for each action. But the prefetch seems a good idea - Does that mean it would call

dnf module

once for each Puppet agent run, then store the results for every resource call?

This message was deleted.

and call new() with the correct properties in self.instances

There's a github setting "Always suggest updating pull request branches" It should give you a button on web interface to rebase. We have this on our gitlab instance, super useful. It does not force you to rebase. Could it be enabled. https://github.blog/changelog/2022-02-03-more-ways-to-keep-your-pull-request-branch-up-to-date/#update-your-pull-request-branch-by-rebasing

frisbee: we already have that enabled on a few modules. if someone wants to enable it for all of them, go ahead

yes, that's the idea

This message was deleted.

bastelfreak: okay though it might be global setting, seems not, I have settings permissions on just some repositories will enable on them.

Maybe we should use terraform to manage all the repos 🤔

we have a repo where afisher startet with that

ewoud: Zhenech https://github.blog/2023-05-16-addressing-githubs-recent-availability-issues/

@emerson_prado or slack<>irc bridge dorsnt handle threads, I suggest to avoid them in this channel

Are there any docs for Puppet::Type.type.provide (or so)

prefetch

method?

@emerson_prado IIRC, the book "Puppet Types and Providers" is quite a good resource for this kind of info.

bastelfreak, nice, thanks

@emerson_prado Also see http://garylarizza.com/blog/2013/12/15/seriously-what-is-this-provider-doing/

though I'm pretty sure that area has changed very little over the past decade

Yeah, I’m not sure anything on that page is out of date. I mean the newer resource API also exists, but the old API has barely changed.

AFAIK newer resource API is a layer on top of the old API

Yes, and is a bit frustrating IMO being just less than feature complete. You bump into a blocker that can only be solved with the low level API and then have to start over…

morning o/

I've a PQL query to get all values from PuppetDB for a specific fact