https://www.puppet.com/community logo
Join SlackCommunities
Powered by
# voxpupuli
  • c

    cruelsmith

    05/10/2023, 2:22 PM
    Could i maybe get a review of https://github.com/puppetlabs/puppetlabs-mysql/pull/1564 Thanks
  • v

    VoxBot

    05/10/2023, 2:27 PM
    and also this https://github.com/voxpupuli/puppet-dnsquery/pull/142 (minor relase for the above pr)
  • c

    cruelsmith

    05/10/2023, 2:53 PM
    jbond: Thanks for the review ❤️
  • v

    VoxBot

    05/10/2023, 2:58 PM
    np
  • c

    cruelsmith

    05/10/2023, 3:15 PM
    jbond: Could you maybe look once more in the PR? I missed to add the RuboCop disable rules in my first commit since i only checked the spec tests. The pipeline has now already been successfully run through. https://github.com/puppetlabs/puppetlabs-mysql/pull/1564 Thx ❤️
  • v

    VoxBot

    05/10/2023, 3:17 PM
    cruelsmith done but i dont think im a code owner for mysql so not sure it counts
    👍 1
  • v

    VoxBot

    05/10/2023, 5:12 PM
    bastelfreak: it would be useful for me to have a puppet-blacksmith 6.1.2 that fixes Dir.exists? and File.exists? so mind if I create that?
  • v

    VoxBot

    05/10/2023, 5:14 PM
    or would that be 6.2.0?
  • v

    VoxBot

    05/10/2023, 5:19 PM
    I think 6.2.0. but I am fine with both
  • v

    VoxBot

    05/10/2023, 5:21 PM
    for the other cherrypick releases I did I always created a $major.x branch based on the last tag, then created a release PR which got merged into that
  • v

    VoxBot

    05/10/2023, 5:21 PM
    https://github.com/voxpupuli/puppet-blacksmith/pull/120
  • v

    VoxBot

    05/10/2023, 5:21 PM
    so git checkout -b 6.x v6.1.1
  • v

    VoxBot

    05/10/2023, 5:21 PM
    ah you already did that
  • v

    VoxBot

    05/10/2023, 5:21 PM
    want me to rename it from 6.2-stable to 6.x?
  • v

    VoxBot

    05/10/2023, 5:22 PM
    puppetlabs uses $majorversion.x, so I copied that
  • v

    VoxBot

    05/10/2023, 5:22 PM
    maybe it makes sense to follow that pattern, but it isn't that important
  • v

    VoxBot

    05/10/2023, 5:23 PM
    bleh, if only GH didn't break …
  • v

    VoxBot

    05/10/2023, 5:24 PM
    https://www.githubstatus.com/ …
  • v

    VoxBot

    05/10/2023, 5:25 PM
    I'll just patch it in $HOME
  • v

    VoxBot

    05/10/2023, 5:30 PM
    they don't like us this week :D
  • v

    VoxBot

    05/10/2023, 5:30 PM
    maybe they do like us to have time off?
  • v

    VoxBot

    05/10/2023, 5:31 PM
    they dare to take that decission from my partner away!
  • v

    VoxBot

    05/10/2023, 5:37 PM
    your partner wants you to nor have time off?
  • v

    VoxBot

    05/10/2023, 5:38 PM
    depends :D
  • v

    VoxBot

    05/10/2023, 5:44 PM
    ha, nice
  • v

    VoxBot

    05/10/2023, 5:44 PM
    https://github.com/nahi/httpclient/issues/440#issuecomment-1542575204
  • v

    VoxBot

    05/10/2023, 5:44 PM
    https://shopify.engineering/that-old-certificate-expired-and-started-an-outage-this-is-what-happened-next
  • v

    VoxBot

    05/10/2023, 6:09 PM
    well, after GH Actions now GH itself is also returning HTTP 500 errors
  • v

    VoxBot

    05/10/2023, 6:09 PM
    time to call it a day
  • b

    binford2k

    05/10/2023, 7:23 PM
    @bastelfreak this is neat https://github.com/cncf/project-template/blob/main/CONTRIBUTOR_LADDER.md
1...470471472...641Latest