https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    05/20/2022, 8:53 PM
    bastelfreak: holy crap
  • j

    jhoblitt

    05/21/2022, 12:06 AM
    well... this is my new excuse for not having iptables rules on top of containerd on my k8s nodes...
  • v

    VoxBot

    05/21/2022, 10:20 AM
    https://github.com/puppetlabs/puppet-lint/pull/40 so who actually looks at puppet-lint?
  • v

    VoxBot

    05/21/2022, 10:36 AM
    ewoud: I guess we do!
  • v

    VoxBot

    05/21/2022, 10:36 AM
    since devx didnt respond in 5 almost half a year I consider it safe to be merged
  • s

    Slackbot

    05/21/2022, 10:37 AM
    This message was deleted.
    🦜 1
    e
    b
    • 3
    • 3
  • m

    Massimiliano (Max)

    05/23/2022, 10:54 AM
    hi everyone o/
  • m

    Massimiliano (Max)

    05/23/2022, 10:55 AM
    with regard to this PR: https://github.com/voxpupuli/puppet-ipset/pull/66
  • m

    Massimiliano (Max)

    05/23/2022, 10:55 AM
    with regard to this PR: https://github.com/voxpupuli/puppet-ipset/pull/66
  • m

    Massimiliano (Max)

    05/23/2022, 10:55 AM
    I tried to contact @Thore Bödecker in Slack, but he doesn't seem to be around.
  • m

    Massimiliano (Max)

    05/23/2022, 10:56 AM
    do you think we can assign the review to someone else ? it's only one change in 1 line, inside a shell script.
  • b

    bastelfreak

    05/23/2022, 10:58 AM
    maybe that's something @Eric Mergelsberg can take a look at as well. He uses/used it
  • v

    VoxBot

    05/23/2022, 2:39 PM
    I am working on getting https://github.com/genebean/genebean-falco/pull/1 ready to transfer to Vox like I talked about last week. I have applied modulesync 5.2.0. When tests run on that PR I feel like I should be seeing some os-specific unit tests run based on what is in metadata.json... anyone know why I am not?
  • v

    VoxBot

    05/23/2022, 2:48 PM
    genebean[m]: for os-specific unit tests you need to use rspec-puppet-facts. those tests are all run in one github job per Puppet major version
  • v

    VoxBot

    05/23/2022, 2:49 PM
    for beaker/acceptance tests, we automatically generate one github job per supported OS major version in metadata.json, if acceptance tests are present
  • v

    VoxBot

    05/23/2022, 2:50 PM
    ah and you already use rspec-puppet-facts for the unit tests
  • v

    VoxBot

    05/23/2022, 2:50 PM
    I do have rspect-puppet-facts setup ... or at least I think I do. When I run
    bundle exec rake spec
    locally I see all the os bits run by.
  • v

    VoxBot

    05/23/2022, 2:51 PM
    yep
  • v

    VoxBot

    05/23/2022, 2:51 PM
    Yeah, I think I was thinking about the acceptance tests as they are what show up as different GH Action tests.
  • v

    VoxBot

    05/23/2022, 2:51 PM
    yep
  • v

    VoxBot

    05/23/2022, 2:51 PM
    Guess I am better off than I realized 🙂
  • v

    VoxBot

    05/23/2022, 2:52 PM
    hehe
  • d

    dhollinger

    05/23/2022, 3:03 PM
    Some webhook-go bugfixes I found when building out the Dockerfile: https://github.com/voxpupuli/webhook-go/pull/55
  • d

    dhollinger

    05/23/2022, 3:03 PM
    Some webhook-go bugfixes I found when building out the Dockerfile: https://github.com/voxpupuli/webhook-go/pull/55
  • s

    Slackbot

    05/23/2022, 3:23 PM
    This message was deleted.
    a
    b
    • 3
    • 3
  • a

    Alex Fisher

    05/23/2022, 3:23 PM
    Anyone wanna quickly approve this trivial PR? https://github.com/voxpupuli/puppet-grafana/pull/281 (I've got a more substantial one coming, but that will also touch the README and probably conflict)
  • d

    dhollinger

    05/23/2022, 3:25 PM
    Make sure goreleaser is releasing GA releases now: https://github.com/voxpupuli/webhook-go/pull/56
  • d

    dhollinger

    05/23/2022, 3:25 PM
    Make sure goreleaser is releasing GA releases now: https://github.com/voxpupuli/webhook-go/pull/56
  • d

    dhollinger

    05/23/2022, 3:27 PM
    Probably going to take a break from working on packaging so that I can update the docs and get the Wiki created for webhook-go
  • v

    VoxBot

    05/23/2022, 3:42 PM
    There isn't a way to have puppet-strings pull from defaults from in-module data, is there?
1...454647...648Latest