https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    04/27/2023, 8:33 PM
    As many tools, it is quite dumb so maybe one day you committed the some generated html content and it count it as relevant. These tools do not have much value, but give insights. I liked ohloh some years ago, it was nice. still exist but crappier that ever unfortunately (openhub now)
  • v

    VoxBot

    04/27/2023, 8:36 PM
    yeah :(
  • a

    Alex Fisher

    04/27/2023, 8:57 PM
    @bastelfreak Do we have any eg. any
    puppet-example
    PR that tries to run unit tests against Puppet 8?
  • d

    Dr Bunsen Honeydew

    04/27/2023, 8:57 PM
    See the
    puppet-example
    module at https://forge.puppet.com/puppet/example?src=slack&channel=voxpupuli
  • b

    bastelfreak

    04/27/2023, 8:58 PM
    not yet and that will also fail
  • b

    bastelfreak

    04/27/2023, 8:58 PM
    or not start a CI job at all, I'm not sure if we released the required puppet_metadata changes I hacked last night
  • a

    Alex Fisher

    04/27/2023, 9:32 PM
    @bastelfreak Are you in a position to cut a new release of voxpupuli-test?
  • a

    Alex Fisher

    04/27/2023, 9:33 PM
    We're going to need https://github.com/voxpupuli/voxpupuli-test/pull/93
  • b

    bastelfreak

    04/27/2023, 9:34 PM
    I can do that tomorrow. I am not on my workstation
  • a

    Alex Fisher

    04/27/2023, 9:34 PM
    ok, cool. I'll just point my puppet-example branch at the git repo.
  • d

    Dr Bunsen Honeydew

    04/27/2023, 9:34 PM
    See the
    puppet-example
    module at https://forge.puppet.com/puppet/example?src=slack&channel=voxpupuli
  • b

    bastelfreak

    04/27/2023, 9:34 PM
    but thats juat bumo version and generate changelov
  • v

    VoxBot

    04/27/2023, 10:02 PM
    bumo changelove
  • s

    smortex

    04/27/2023, 10:05 PM
    @bastelfreak @Alex Fisher I am on it
  • s

    smortex

    04/27/2023, 10:06 PM
    I guess 93 should be labelled "bug" and we should issue a patch release?
  • s

    smortex

    04/27/2023, 10:07 PM
    or is that a feature?
  • s

    smortex

    04/27/2023, 10:08 PM
    or I left it that way 🤷 that looks okay I think
  • s

    smortex

    04/27/2023, 10:17 PM
    Hum… a test is using an older version of Puppet 🤔
  • s

    smortex

    04/27/2023, 10:17 PM
    https://github.com/voxpupuli/voxpupuli-test/actions/runs/4824870014/jobs/8595159462
  • a

    Alex Fisher

    04/27/2023, 10:39 PM
    Didn't that come up earlier today? (for something else probably)
  • a

    Alex Fisher

    04/27/2023, 10:41 PM
    I think it's just one of those cases where bundler doesn't know if you prefer latest puppet, or latest concurrent-ruby
  • a

    Alex Fisher

    04/27/2023, 10:46 PM
    Suggest updating https://github.com/voxpupuli/voxpupuli-test/blob/4062ec4a366309e0a12ef62d142b3da2ec0e4c17/.github/workflows/test.yml#L29 to
    ~> 7.22.0
    ?
  • a

    Alex Fisher

    04/27/2023, 10:50 PM
    or
    ~> 7.24.0
  • r

    rusty

    04/27/2023, 10:54 PM
    I wouldn't recommend the
    .0
    else won't it restrict to
    7.24.x
    ? IIRC, the minor did need to bump due to bundler issues, so
    ~> 7.24
    should work. See discussion around
    6.29
    from yesterday (?).
  • r

    rusty

    04/27/2023, 10:55 PM
    I still prefer that longer, but much less ambiguous
    >=6, < 7
    over
    ~>
    I've seen way too much confusion over how it actually works
  • a

    Alex Fisher

    04/27/2023, 11:00 PM
    yeah, but with that environment variable you can't specify two conditions.
  • a

    Alex Fisher

    04/27/2023, 11:00 PM
    oh hang on. let me re-read that...
  • a

    Alex Fisher

    04/27/2023, 11:03 PM
    @rusty ++
  • d

    Dr Bunsen Honeydew

    04/27/2023, 11:03 PM
    rusty is on the rise! (Karma: 1)
  • a

    Alex Fisher

    04/27/2023, 11:04 PM
    You're right. My bad.
1...447448449...642Latest