https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • c

    Craig Gumbley

    04/24/2023, 8:58 AM
    if anyone has a differing opinion though please share
  • b

    bastelfreak

    04/24/2023, 8:59 AM
    so bugfix is fine I think
  • c

    Craig Gumbley

    04/24/2023, 9:13 AM
    Removed the changelog update from the PR
  • c

    Craig Gumbley

    04/24/2023, 9:22 AM
    @bastelfreak thanks so much for your help with this 🙏
  • b

    bastelfreak

    04/24/2023, 9:31 AM
    @Craig Gumbley we already merged https://github.com/voxpupuli/json-schema/pull/465 so the next release will be a major one. do you require Ruby 2.5/2.6 support? we wanted to drop that as well
  • b

    bastelfreak

    04/24/2023, 9:31 AM
    maybe makes sense to split that into different major releases
  • b

    bastelfreak

    04/24/2023, 9:42 AM
    talked to ewoud, we will split it
  • l

    Lukas Audzevicius

    04/24/2023, 9:42 AM
    Massive thanks to @bastelfreak and ekolh for lending a hand with puppetlabs/stdlib in sorting some of the pending PRs over there. Really appreciate the help and will try to get a release sorted asap.
    ❤️ 1
  • d

    Dr Bunsen Honeydew

    04/24/2023, 9:42 AM
    See the
    puppetlabs-stdlib
    module at https://forge.puppet.com/puppetlabs/stdlib?src=slack&channel=voxpupuli
  • b

    bastelfreak

    04/24/2023, 9:42 AM
    I'm good at pressing buttons!
    keanu thanks 1
  • b

    bastelfreak

    04/24/2023, 9:46 AM
    can I get a review for https://github.com/voxpupuli/json-schema/pull/493
  • a

    Alex Fisher

    04/24/2023, 10:09 AM
    @bastelfreak It's a shame that jruby doesn't end up with a release that matches each MRI ruby version.
  • b

    bastelfreak

    04/24/2023, 10:10 AM
    they are a bit slower, to my understanding due to missing developers
  • a

    Alex Fisher

    04/24/2023, 10:10 AM
    it's more that some ruby versions end up getting skipped.
  • a

    Alex Fisher

    04/24/2023, 10:11 AM
    So there might never be a jruby that matches ruby 3.2.
  • a

    Alex Fisher

    04/24/2023, 10:13 AM
    Anyway... on the subject of the next stdlib major bump, is there some deprecated stuff that could get dropped whilst we're at it?
  • a

    Alex Fisher

    04/24/2023, 10:14 AM
    Like all the functions where the core puppet version gets used instead?
    ➕ 2
  • a

    Alex Fisher

    04/24/2023, 10:16 AM
    There are 108 instances of the word deprecated in REFERENCE.MD
  • b

    bastelfreak

    04/24/2023, 10:20 AM
    yes please
  • b

    bastelfreak

    04/24/2023, 10:20 AM
    https://github.com/voxpupuli/json-schema/pull/478 can I get a review please?
  • l

    Lukas Audzevicius

    04/24/2023, 10:41 AM
    @Alex Fisher Yes, we have actually discussed this a bit earlier. However, we are currently a bit limited in resources so we are not fully sure we can commit to removing all deprecated functions. Some people suggested doing a bug bash and even started to contribute to it > https://github.com/puppetlabs/puppetlabs-stdlib/pull/1309
  • a

    Alex Fisher

    04/24/2023, 10:43 AM
    Oh cool. If I get some spare cycles I’ll see about throwing a PR or two in.
    👍 1
    t hanks 1
  • l

    Lukas Audzevicius

    04/24/2023, 10:45 AM
    This also means we will be dropping a release very soon (so as to avoid the function deprecation PR from becoming part of a pre-release). So if anyone has any pending PRs they want to get merged in before we cut a major one for stdlib, probably the next 2-3 hours are the last chance to get it sorted.
  • m

    Marty Ewings

    04/24/2023, 10:47 AM
    yeah i started with the puppet 3 and 4 deprecations, the ones with little reference and just the actual function and unit tests
  • m

    Marty Ewings

    04/24/2023, 10:47 AM
    ill though as many out as i have time to do so
  • c

    Craig Gumbley

    04/24/2023, 10:49 AM
    @bastelfreak thanks for sorting out that release for me 🙂
  • c

    Craig Gumbley

    04/24/2023, 10:50 AM
    guessing that there will be another major release to drop the rubies at some point in the future
  • b

    bastelfreak

    04/24/2023, 10:50 AM
    sure, you are welcome
  • b

    bastelfreak

    04/24/2023, 10:50 AM
    yes
  • b

    bastelfreak

    04/24/2023, 10:50 AM
    as soon as ewould accepts my PR 😄
1...427428429...647Latest