https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    03/31/2023, 9:45 AM
    yes, that was my goal with the helpers: don't pull in beaker-pe at all anymore
  • v

    VoxBot

    03/31/2023, 9:45 AM
    yeah
  • v

    VoxBot

    03/31/2023, 9:45 AM
    if we move to Beaker 5, perhaps that's a good moment to migrate
  • v

    VoxBot

    03/31/2023, 9:48 AM
    that would be nice
  • v

    VoxBot

    03/31/2023, 9:53 AM
    ewoud: whats missing for the migration?
  • v

    VoxBot

    03/31/2023, 9:53 AM
    bastelfreak: time? :P
  • v

    VoxBot

    03/31/2023, 9:53 AM
    yeah if course :D
  • v

    VoxBot

    03/31/2023, 9:54 AM
    I meant from a technical point of view
  • v

    VoxBot

    03/31/2023, 9:54 AM
    bastelfreak: I think https://github.com/voxpupuli/voxpupuli-acceptance/pull/31 needs a rebase and then try it out on some modules
  • v

    VoxBot

    03/31/2023, 9:54 AM
    and looking at the TODOs there the gem needs a release
  • v

    VoxBot

    03/31/2023, 12:04 PM
    ewoud: what about beaker-module_install_helper? do you want to keep using that?
  • y

    Yury Bushmelev

    03/31/2023, 12:12 PM
    I can test some changes on my vaultbot module fyi
  • y

    Yury Bushmelev

    03/31/2023, 12:13 PM
    It’s not in voxpupuli infra but I’m using beaker-docker for tests
  • b

    bastelfreak

    03/31/2023, 12:14 PM
    can you review https://github.com/voxpupuli/beaker_puppet_helpers/pull/5 ?
  • b

    bastelfreak

    03/31/2023, 12:14 PM
    can you review https://github.com/voxpupuli/beaker_puppet_helpers/pull/5 ?
  • b

    bastelfreak

    03/31/2023, 12:14 PM
    mhm rubocop isn't a fan today
  • v

    VoxBot

    03/31/2023, 12:16 PM
    (never was)
  • v

    VoxBot

    03/31/2023, 12:29 PM
    bastelfreak: not really
  • v

    VoxBot

    03/31/2023, 12:36 PM
    now I built 5 PRs on top of each other and CI won't pass
  • v

    VoxBot

    03/31/2023, 12:36 PM
    sad moment
  • v

    VoxBot

    03/31/2023, 12:37 PM
    https://github.com/voxpupuli/beaker_puppet_helpers/pull/8
  • v

    VoxBot

    03/31/2023, 12:37 PM
    that looks like an argument error
  • v

    VoxBot

    03/31/2023, 12:57 PM
    https://github.com/voxpupuli/puppet-prometheus/actions/runs/4575234496/jobs/8077840264 \o/
  • v

    VoxBot

    03/31/2023, 12:57 PM
    works, with beaker-module_install_helper
  • v

    VoxBot

    03/31/2023, 1:03 PM
    mhm or maybe not
  • v

    VoxBot

    03/31/2023, 1:04 PM
    ah the example installs an additional module
  • v

    VoxBot

    03/31/2023, 1:33 PM
    ~/code/modulesync_config/modules/voxpupuli $ grep install_module_from_forge puppet-*/spec/ -r | wc -l
  • v

    VoxBot

    03/31/2023, 1:33 PM
    ewoud: maybe it makes sense to provide a wrapper around install_puppet_module_via_pmt_on that's named install_module_from_forge
  • v

    VoxBot

    03/31/2023, 1:33 PM
    bastelfreak: hmm yes
  • v

    VoxBot

    03/31/2023, 1:34 PM
    dang
1...396397398...648Latest