https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    03/28/2023, 9:27 PM
    Ack
  • v

    VoxBot

    03/28/2023, 9:32 PM
    https://github.com/voxpupuli/voxpupuli-acceptance/pull/46 and I guess a new patch release will fix it
  • v

    VoxBot

    03/28/2023, 9:38 PM
    merged
  • v

    VoxBot

    03/28/2023, 9:39 PM
    can you please do the release pr? I am currently on my phone
  • v

    VoxBot

    03/28/2023, 10:11 PM
    bastelfreak: back from eating
  • v

    VoxBot

    03/28/2023, 10:11 PM
    i do it right now
  • v

    VoxBot

    03/28/2023, 10:19 PM
    https://github.com/voxpupuli/voxpupuli-acceptance/pull/47
  • v

    VoxBot

    03/28/2023, 10:23 PM
    approved
  • b

    bastelfreak

    03/29/2023, 7:48 AM
    @Robert Waffen when you've some time can you take a look at https://github.com/voxpupuli/plumbing/issues/270#issuecomment-1485833678 and provide me your gpg key + upload it to the two keyservers?
    ๐Ÿ‘€ 1
    ๐Ÿ‘ 1
  • b

    bastelfreak

    03/29/2023, 7:48 AM
    @Robert Waffen when you've some time can you take a look at https://github.com/voxpupuli/plumbing/issues/270#issuecomment-1485833678 and provide me your gpg key + upload it to the two keyservers?
  • v

    VoxBot

    03/29/2023, 11:28 AM
    o/
  • v

    VoxBot

    03/29/2023, 11:28 AM
    max_adamo: o/
  • y

    Yury Bushmelev

    03/29/2023, 1:08 PM
    ewoud: I need your advice about another aspect of rspec tests.. I think the 2 examples here are mostly useless: https://github.com/voxpupuli/beaker-docker/blob/master/spec/beaker/hypervisor/docker_spec.rb#L147. I see no real reason to do so.. am I wrong?
  • y

    Yury Bushmelev

    03/29/2023, 1:08 PM
    ewoud: I need your advice about another aspect of rspec tests.. I think the 2 examples here are mostly useless: https://github.com/voxpupuli/beaker-docker/blob/master/spec/beaker/hypervisor/docker_spec.rb#L147. I see no real reason to do so.. am I wrong?
  • y

    Yury Bushmelev

    03/29/2023, 1:08 PM
    I mean
    it 'requires the docker gem'
    and
    it 'fails when the gem is absent'
    examples
  • v

    VoxBot

    03/29/2023, 1:09 PM
    hmm, good question
  • v

    VoxBot

    03/29/2023, 1:10 PM
    we have a dependency on docker-api, so I wonder what sense it makes
  • v

    VoxBot

    03/29/2023, 1:10 PM
    feels like that's something you'd do for soft dependencies
  • v

    VoxBot

    03/29/2023, 1:11 PM
    so I share your view that there's no real reason to do so
  • y

    Yury Bushmelev

    03/29/2023, 1:11 PM
    exactly.. and those *_any_instance_of are hard to rewrite.. so maybe itโ€™s ok to drop this ๐Ÿ™‚
  • y

    Yury Bushmelev

    03/29/2023, 1:12 PM
    exactly.. and those *_any_instance_of are hard to rewrite.. so maybe itโ€™s ok to drop this ๐Ÿ™‚
  • v

    VoxBot

    03/29/2023, 1:13 PM
    now that I read it more, I think I start to understand it: it essentially wants to test that the Docker gem really isn't used and completely stubbed out so they're pure unit tests
  • y

    Yury Bushmelev

    03/29/2023, 1:14 PM
    well.. here I dropped some strange things: https://github.com/voxpupuli/beaker-docker/pull/116
  • y

    Yury Bushmelev

    03/29/2023, 1:14 PM
    well.. here I dropped some strange things: https://github.com/voxpupuli/beaker-docker/pull/116
  • v

    VoxBot

    03/29/2023, 1:15 PM
    I think if you really want to properly design it you'd introduce a DockerWrapper class that all of the docker API interactions and Beaker::Docker just ties Beaker and DockerWrapper together
  • v

    VoxBot

    03/29/2023, 1:16 PM
    then in the unit tests you would stub DockerWrapper
  • y

    Yury Bushmelev

    03/29/2023, 1:17 PM
    that requires almost full redesign of the spec Iโ€™d say.. ๐Ÿค”
  • y

    Yury Bushmelev

    03/29/2023, 1:17 PM
    that requires almost full redesign of the spec Iโ€™d say.. ๐Ÿค”
  • v

    VoxBot

    03/29/2023, 1:17 PM
    s/spec/gem/ ;)
  • y

    Yury Bushmelev

    03/29/2023, 1:17 PM
    and gem too ๐Ÿ˜„
1...394395396...648Latest