# voxpupuli
- b
bastelfreak
03/28/2023, 1:07 PM\o/ - m
Massimiliano (Max)
03/28/2023, 1:07 PMo/ - v
VoxBot
03/28/2023, 1:08 PM<3 git rebase -i and use x bundle exec rubocop -a after every commit - m
Massimiliano (Max)
03/28/2023, 1:15 PMdoes anyone have time to review this PR? It's an important one, as we're not able to use ipset with newer kernel (i.e. with Ubuntu 22.04 which was released a year ago). https://github.com/voxpupuli/puppet-ipset/pull/81 - m
Massimiliano (Max)
03/28/2023, 1:15 PMdoes anyone have time to review this PR? It's an important one, as we're not able to use ipset with newer kernel (i.e. with Ubuntu 22.04 which was released a year ago). https://github.com/voxpupuli/puppet-ipset/pull/81 - s
Slackbot
03/28/2023, 1:17 PMThis message was deleted.m- 2
- 1
- s
sebastianrakel
03/28/2023, 1:31 PM@sebastianrakel has left the channel - s
Slackbot
03/28/2023, 1:44 PMThis message was deleted.s- 2
- 1
- m
Massimiliano (Max)
03/28/2023, 2:13 PMI've had a look, but my comments are not really valuable for this type of change 🙂 - c
Craig Gumbley
03/28/2023, 6:17 PM👋 What is the vox preference for this cop -> https://www.rubydoc.info/github/bbatsov/RuboCop/RuboCop/Cop/Style/ClassAndModuleChildren We seem to be somewhat inconsistent. I’m interested in potential alignment opportunities - b
bastelfreak
03/28/2023, 6:18 PMmy opinion is to stick with the rubocop default for this. maybe ewoud or @Alex Fisher have other ideas - c
Craig Gumbley
03/28/2023, 6:22 PMthe default does appear to be less problematic for sure - v
VoxBot
03/28/2023, 6:38 PMyes, I'd also go with the default but modules in Ruby are still a weird thing - v
VoxBot
03/28/2023, 7:39 PMI would also vote for the default. Most codebases I've worked on format the code in the style defined in the default. It can be annoying with indentation sometimes, but it is easier to read/understand👍 1 - v
VoxBot
03/28/2023, 7:51 PMyes, and too deep namespaces are often not needed anyway - v
VoxBot
03/28/2023, 7:51 PMso if you find yourself with 5 levels of indentation because of modules, you either have a very complex project or you're making it too complex👍 1 - v
VoxBot
03/28/2023, 7:56 PMewoud: Spritzgebaeck smortex are you interested in a vox pupuli cloak like voxpupuli/pmc/$nickname ? - s
Slackbot
03/28/2023, 7:57 PMThis message was deleted.rb- 3
- 3
- y
Yury Bushmelev
03/28/2023, 8:01 PMNeed a review from local RSpec guru here: https://github.com/voxpupuli/beaker-docker/pull/115✔️ 1 - y
Yury Bushmelev
03/28/2023, 8:01 PMNeed a review from local RSpec guru here: https://github.com/voxpupuli/beaker-docker/pull/115 - y
Yury Bushmelev
03/28/2023, 8:12 PMYay, just one RSpec cop is left there 😄 - y
Yury Bushmelev
03/28/2023, 8:13 PMnot sure what is default for RSpec/MessageSpies btw.. it’s set to
nowreceive - y
Yury Bushmelev
03/28/2023, 8:13 PMmaybe we can drop it and replace everything tohave_received - v
VoxBot
03/28/2023, 8:43 PMbastelfreak: o/ - v
VoxBot
03/28/2023, 8:43 PMsmortex: o/ - v
VoxBot
03/28/2023, 8:44 PMi still have not understood what is the purpose of a "cloack" :-) /me is an IRC noobx - v
VoxBot
03/28/2023, 8:45 PMother can identify to which project you're associated - v
VoxBot
03/28/2023, 8:45 PMyou can do
as an example/whois bastelfreak - v
VoxBot
03/28/2023, 8:45 PMit lets you have a pretty /whois :-D - v
VoxBot
03/28/2023, 8:45 PM(if you client supports it)