https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v
    ewoud: do you think we can merge https://github.com/voxpupuli/beaker-hostgenerator/pull/275 if you rebase it
  • v
    and I need to make the tests pass
  • v
    details, details
  • v
    rm -rf spec && echo done
  • v
    oh wait, the fixtures are mostly in test/
  • r
    it's not easy to be green, but then again, no tests are also green thonk
  • v
    I always like rspec when it says: 100% tests passed (zero out of zero)
  • v
  • v
    I think someone was arguing recently that a testsuite should by default FAIL if there were no tests executed
  • v
    hands up if you ever forgot to add _test or _spec to a filename and it wasn't executed
  • v
    ✋
  • v
    raises hand
  • v
    or wrong directory or misspelled
  • v
    same for test_ function prefix in pytest
  • v
    and you can also mess them up because you were previously working in a project which used a _test suffix
  • v
    I don't like coverage tests, but a check that verifies all files in test/ or spec/ were at least loaded in your test suite would actually be useful
  • v
    ansible-lint has a config file that says how many tests need to pass
  • v
  • v
    every time I add a test, I forget to bump that value and CI fails
  • v
    but it also ensures that no tests are accidentally skipped
  • v
    Zhenech: and the lint wont pass when you've more tests?
  • v
    no
  • v
    (as otherwise people will forget to bump that number :>)
  • v
    lol
  • v
    in rspec-puppet we can set a minimal value for the coverage
  • v
    which brings us back to the root of all problems: people
  • v

    https://www.youtube.com/watch?v=eVSlE28hOgI▾

  • v
    IT crowd <3
  • v
  • v
1...388389390...648Latest