https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    03/17/2023, 3:58 PM
    gave it another thought: I don't think beaker usually terminates containers after a connection is terminated
  • v

    VoxBot

    03/17/2023, 3:58 PM
    a normal beaker run uses multiple scp connections and I also think multiple ssh connections, all sequentially
  • v

    VoxBot

    03/17/2023, 3:59 PM
    well, it calls host.close explicitly and we usually don't do that
  • v

    VoxBot

    03/17/2023, 3:59 PM
    ah
  • v

    VoxBot

    03/17/2023, 3:59 PM
    ok that terminate it
  • v

    VoxBot

    03/17/2023, 3:59 PM
    it worked for you locally with vagrant?
  • v

    VoxBot

    03/17/2023, 4:00 PM
    yes
  • v

    VoxBot

    03/17/2023, 4:00 PM
    mhm
  • v

    VoxBot

    03/17/2023, 4:00 PM
    so now I'm testing with a condition on the hypervisor to skip it on docker, see if that works
  • v

    VoxBot

    03/17/2023, 4:01 PM
    kind of weird https://github.com/voxpupuli/beaker/actions/runs/4449290275/jobs/7813262694 doesn't show output
  • v

    VoxBot

    03/17/2023, 4:02 PM
    I wonder if it's buffering output
  • v

    VoxBot

    03/17/2023, 4:18 PM
    bleh, looks like net-scp also closes the connection if something fails
  • v

    VoxBot

    03/17/2023, 4:20 PM
    meh
  • v

    VoxBot

    03/17/2023, 4:20 PM
    tests were probably never executed on docker
  • v

    VoxBot

    03/17/2023, 4:20 PM
    very likely
  • v

    VoxBot

    03/17/2023, 4:21 PM
    though there is https://github.com/voxpupuli/beaker/blob/19b8ddaf426c073fa38c5bc1fb0e172c67ceb426/acceptance/lib/helpers/test_helper.rb#L1-L9 so it's not like it never caused problems before
  • v

    VoxBot

    03/17/2023, 4:21 PM
    interesting
  • y

    Yury Bushmelev

    03/17/2023, 4:25 PM
    Hmm.. is the case just with sshd as docker_cmd?
  • v

    VoxBot

    03/17/2023, 4:25 PM
    now testing with the released gem version
  • v

    VoxBot

    03/17/2023, 5:27 PM
    hmmm, I also wonder why rsync is broken on beaker-docker, which makes me wonder if SSH is even running at all on the container
  • v

    VoxBot

    03/17/2023, 5:28 PM
    I think it does successful ssh connections?
  • v

    VoxBot

    03/17/2023, 5:29 PM
    or SSH is not properly deamonized and only accepts a single connection?
  • v

    VoxBot

    03/17/2023, 5:29 PM
    mhm, I think even when you start it foreground it accepts multiple connections
  • v

    VoxBot

    03/17/2023, 5:30 PM
    rsync returned #<Rsync:Result0x00007fbc30739800 @raw="ssh: connect to host 172.17.0.2 port 1991: Connection refused\r\nrsync: connection unexpectedly closed (0 bytes received so far) [sender]\nrsync error: unexplained error (code 255) at io.c(235) [sender=3.1.3]\n", @exitcode=255>
  • v

    VoxBot

    03/17/2023, 5:48 PM
    mhm
  • y

    Yury Bushmelev

    03/17/2023, 5:50 PM
    Does it happen only on Ruby 3.2 with the latest changes?
  • v

    VoxBot

    03/17/2023, 5:50 PM
    no, I tested on Ruby 3.2
  • v

    VoxBot

    03/17/2023, 5:50 PM
    3.1*
  • v

    VoxBot

    03/17/2023, 5:51 PM
    the generated dockerfile doesn't look different compared to our usual module CI jobs
  • v

    VoxBot

    03/17/2023, 5:52 PM
    no, it's calling beaker-hostgenerator so that should be what we're used to
1...369370371...648Latest