Puppet Community

it allows greater flexibility, since you can also use --only to fix just a single cop

<https://github.com/voxpupuli/beaker-docker/pull/75/files#diff-ee98e028c59b193d58fde56ab4daf54d43c486ae674e63d50ddf300b07943e0fR17>

well.. then I can drop it from there :slightly_smiling_face:

and today I wanted to finish my backup work; thanks bastelfreak for triggering me on Beaker + RuboCop ;)

my idea was to improve it to fix one cop at a time.. but had no chance to update it yet

i.e. `rake rubocop:fix_next` to autofix one cop and make a commit

<https://github.com/voxpupuli/beaker-docker/pull/93#discussion_r1140262089> I'd like your thoughts on that one

changing it to Array(docker_cmd).first would make it work, but that's actually changing the implementation

I didn’t know =~ was able to match arrays too :thinking_face:

and in 3.1 it returns nil, probably earlier versions too

I wonder if that's correct, since you really want to check the command I think

well.. the problem here is.. it can be not the [0]th item..

so I think ['some_command', 'with_sshd'] shouldn't match

then we should say sshd should be in `host[:docker_cmd][0]`

which is what Array(host[:docker_cmd]).first does, but it works for both Array and String

then your solution is fine (+ changelog record)

since Array('sshd') == Array(['sshd']) == ['sshd']

I think it reflects a past period where Puppet org was not communicating and developing together with Vox properly so to be fair i think divergence was inevitable.

While there will be always be some difference in approach hopefully what we should be seeing out of the new ecosystem product team is a far greater focus to narrow these differences and reduce duplication of work by working together.

That sounds nice and all but at the end of the day, are you going to get people to agree with a template rubocop.yaml vs the pdk-way of using .sync.yaml to make it how you want? I don't exactly like how PDK handles rubocop config, but for me it is _far_ preferred over using sed as a means of configuring a new project.