I always keep this rule in my head: syncing code is an anti-pattern, but sometimes a necessary evil

I like the way module sync handles things and I like the fact that it is optional

so in practice that means using gems to ship code if you can

build instructions for pdk against system ruby would also help. pdk ships ancient ruby and packages aren't provided for all platforms

(same for bolt)

and reusable GitHub workflows, so I wrote https://github.com/voxpupuli/gha-puppet

but if you have questions, I'd be happy to help you get rid of synced code

and https://github.com/voxpupuli/voxpupuli-test carries a rubocop config, so you only need 2 lines in your .rubocop.yml

the feedback I have seen suggests that some people don’t like PDK controlling the whole module by default… it will be a fun journey. Re system build. The gem seems to work alright for 2.7 for the most part.. but largely would need work to make sure the version selection doesn’t become confusing

with the more minimal synced files it becomes much easier to avoid syncing a file altogether

Yeah agree

and I worked hard to make sure that adding an OS version as supported is just adding it to metadata.json, though I think PDK is also at that level now, which is an excellent place to be in

This message was deleted.

bastelfreak: given you're awake I guess you're back in a European timezone

back: yes. Awake? kinda

I didn't travel to the US and I'm not sure I'm quite awake :P

:D

bastelfreak: https://github.com/voxpupuli/rspec-puppet-facts/pull/146 it's rather large now, but I kind of prefer this

I'm totally fine with it

bastelfreak: FYI: I'm taking a stab at running beaker acceptance tests in CI, but I'm start to realize my removal of deprecated methods didn't look at that

ah

https://github.com/voxpupuli/beaker/pull/1784 worked locally with vagrant_libvirt as hypervisor, let's see about CI

bleh, 3.2 fails because of beaker-docker

yeah, same problem I saw in beaker-rspec :(

Back to PDK thread (I’m not using the threads as those are not really good for our IRC users).. I like that puppet agent, PDK and Bolt all have Ruby bundled with them.. So my strong opinion is to keep it distributed in this way. Though it might be good idea to simplify using them as Ruby gems. Then those who would like to use their own Ruby can do it easily… Just my $2c

Wrt default_facts I agree as there is nice

on_supported_os

which should be used everywhere 🙂

If you need to support legacy systems it's good to vendor ruby. but on modern systems I prefer to use system ruby/openssl/curl

I don’t want to manage Ruby on my MacOS or Windows 🙂

and I would be happy if Puppet would provide build instructions against system ruby/openssl/curl

And then yes, we need some common GHA for PDK-based module validating/testing (no rocket science but still someone should spent some time on it..)