https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • v

    VoxBot

    03/16/2023, 12:00 PM
    I do: https://github.com/voxpupuli/modulesync_config
  • y

    Yury Bushmelev

    03/16/2023, 12:00 PM
    or at least your own
    .sync.yml
  • v

    VoxBot

    03/16/2023, 12:00 PM
    but then you open a third party module …
  • v

    VoxBot

    03/16/2023, 12:01 PM
    things like this trigger me: https://github.com/voxpupuli/pdk-templates/blob/bb554cbb831d8c651cd54056ac09950228603e5e/moduleroot/spec/spec_helper.rb.erb#L57-L59
  • v

    VoxBot

    03/16/2023, 12:02 PM
    there's already https://github.com/puppetlabs/puppetlabs_spec_helper/blob/6d49745eb3b5e4bcceaf91f166ec27a543fd5f91/lib/puppetlabs_spec_helper/module_spec_helper.rb#L80
  • v

    VoxBot

    03/16/2023, 12:02 PM
    but that's even weird because rspec-puppet has a proper option for that: https://github.com/puppetlabs/rspec-puppet#strict_variables
  • y

    Yury Bushmelev

    03/16/2023, 12:03 PM
    Raise a PR into templates repo to use RSpec option instead
  • v

    VoxBot

    03/16/2023, 12:04 PM
    yes, but that's how I always get distracted
  • y

    Yury Bushmelev

    03/16/2023, 12:04 PM
    somehow I was sure RSpec config option was used 🤔
  • v

    VoxBot

    03/16/2023, 12:04 PM
    I just want to use restic, not fix infrastructure :(
  • v

    VoxBot

    03/16/2023, 12:05 PM
    and now I woner why there's no option for strict in rspec-puppet
  • v

    VoxBot

    03/16/2023, 12:08 PM
    at least I've opened https://github.com/puppetlabs/rspec-puppet/issues/47
  • v

    VoxBot

    03/16/2023, 12:11 PM
    and https://github.com/puppetlabs/puppetlabs_spec_helper/pull/389 should fix another part
  • v

    VoxBot

    03/16/2023, 12:13 PM
    https://github.com/puppetlabs/puppetlabs_spec_helper/commit/6dd1f530a97c3005be1a480472bdb1ef1ba7fd0e is also an interesting one: I wonder if that should have also been done in rspec-puppet
  • y

    Yury Bushmelev

    03/16/2023, 12:52 PM
    TY for that! 🙇🏻
  • b

    Brian Schonecker

    03/16/2023, 1:39 PM
    I'm trying to integrate voxpupuli testing in my new Puppet module and am having a problem with the Github action. The puppet-lint scanning job is failing because it can't resolve a dependency on rubocop-spec. This is new territory for me and I'm unsure how to go about resolving the problem. I created my module with 'pdk new module' (or something like that) so I'm sure I've got a lot of cruft that doesn't need to be there. I've checked out puppet-chrony for clues on how to get my Github action working but so far I'm at a loss. My best guess is a hardcoded version of rubocop and related gem files but there are several hard-coded gems in there and I'm afraid to start poking around. Any suggestion or pull request is much appreciated to get me over this hump.
  • v

    VoxBot

    03/16/2023, 1:41 PM
    where is the code it ran on?
  • v

    VoxBot

    03/16/2023, 1:41 PM
    is that https://github.com/bschonec/puppet-ivanti/tree/8-implement-voxpupuli-ci-cd-tests ?
  • b

    Brian Schonecker

    03/16/2023, 1:42 PM
    yes
  • b

    Brian Schonecker

    03/16/2023, 1:43 PM
    I copied puppet-chrony Gemfile verbatim to my Gemfile and the puppet-lint scanning action succeeded.
  • d

    Dr Bunsen Honeydew

    03/16/2023, 1:43 PM
    See the
    puppet-chrony
    module at https://forge.puppet.com/puppet/chrony?src=slack&channel=voxpupuli
  • b

    Brian Schonecker

    03/16/2023, 1:44 PM
    Well, succeeded in ruby related stuff. The puppet-lint failed due to some syntax issues in my manifest.
  • v

    VoxBot

    03/16/2023, 1:45 PM
    what I'd start with is cloning https://github.com/voxpupuli/modulesync_config, run bundle install, change managed_modules to bschonec/puppet-ivanti and run bundle exec msync update --noop -b 8-implement-voxpupuli-ci-cd-tests
  • v

    VoxBot

    03/16/2023, 1:45 PM
    right now I'm trying that out, but running into https://github.com/voxpupuli/modulesync/pull/260 myself, so one moment
  • b

    Brian Schonecker

    03/16/2023, 1:46 PM
    Yikes! That sounds daunting for a noob like me. Thank you. I'll try your suggestion and report back.
  • v

    VoxBot

    03/16/2023, 1:49 PM
    I've often wondered about structuring our repo so you could use PDK, but I never bothered myself since I refuse to use PDK since sends analytics by default
  • v

    VoxBot

    03/16/2023, 1:50 PM
    but after you do that, you should be able to see a git checkout in modules/bschonec/puppet-ivanti with all the files templated according to Vox Pupuli's CI setup
  • v

    VoxBot

    03/16/2023, 1:54 PM
    I didn't check the details, but https://github.com/bschonec/puppet-ivanti/pull/3 is what I'd start with
  • b

    Brian Schonecker

    03/16/2023, 1:55 PM
    Thank you. I think this will really help me to start moving forward with Voxpupuli.
  • v

    VoxBot

    03/16/2023, 2:01 PM
    oh, and I think .devcontainer should also be dropped
1...361362363...648Latest