https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • p

    Pat Riehecky

    03/13/2023, 3:18 PM
    Looks like I've got some work ahead of me
  • v

    VoxBot

    03/13/2023, 3:18 PM
    2.5 and Puppet 6 are EOL now
  • v

    vchepkov

    03/13/2023, 6:43 PM
    is there legacy_check linter that will check hiera.yaml, by any chance ?
  • b

    bastelfreak

    03/13/2023, 6:53 PM
    as far as I know all the puppet-lint plugins only check actual puppet code
  • v

    vchepkov

    03/13/2023, 6:57 PM
    yep. so need something for hiera.yaml and lib/facter/
  • a

    Alex Fisher

    03/13/2023, 8:11 PM
    And templates…
    💯 1
  • b

    bastelfreak

    03/13/2023, 8:14 PM
    one idea we had was to disable legacy checks in puppet, when running puppet 7/8 unit tests
  • b

    bastelfreak

    03/13/2023, 8:20 PM
    *legacy facts
  • s

    smortex

    03/13/2023, 8:20 PM
    test runs with legacy facts disabled / strict mode would be great
  • s

    smortex

    03/13/2023, 8:20 PM
    test runs with legacy facts disabled / strict mode would be great
  • b

    bastelfreak

    03/13/2023, 8:20 PM
    I'm happy to review your patch for this!
  • b

    bastelfreak

    03/13/2023, 8:20 PM
    😄
  • b

    bastelfreak

    03/13/2023, 8:20 PM
    probably an rspec-puppet option in voxpupuli-test
  • b

    bastelfreak

    03/13/2023, 8:21 PM
    https://github.com/voxpupuli/voxpupuli-test/blob/master/lib/voxpupuli/test/spec_helper.rb
  • b

    bastelfreak

    03/13/2023, 8:21 PM
    https://github.com/voxpupuli/voxpupuli-test/blob/master/lib/voxpupuli/test/spec_helper.rb
  • s

    smortex

    03/13/2023, 8:23 PM
    Yeah, not sure if we want to duplicate the what we currently have and this for all projects since when I started to do this on my control repo (disabling legacy facts only) I had to open a bunch of PR and some of them are still not merged (not in vox I think)
  • s

    smortex

    03/13/2023, 8:24 PM
    *want to duplicate what we currently have and this new behavior for all projects
  • b

    bastelfreak

    03/13/2023, 8:24 PM
    since that's enabled by default in puppet 8, I assume the unit tests will have it enabled by default as well
  • b

    bastelfreak

    03/13/2023, 8:24 PM
    so we just need to enable puppet 8 testing
  • s

    smortex

    03/13/2023, 8:25 PM
    I am fine with it 🙂
  • b

    bastelfreak

    03/13/2023, 8:25 PM
    and if someone wants to work on that: we could already enable puppet 8 testing with the git repo
  • v

    vchepkov

    03/13/2023, 8:29 PM
    yeah, puppetlabs have quite a few with legacy facts
  • v

    vchepkov

    03/13/2023, 8:30 PM
    starting with puppet_agent, ironically
  • b

    bastelfreak

    03/13/2023, 8:31 PM
    oh don't get me started on that one
  • v

    VoxBot

    03/13/2023, 8:31 PM
    we're working on eradicating legacy facts in the Supported modules now
    👍 1
  • v

    VoxBot

    03/14/2023, 7:47 AM
    Hi, I'm looking for smortex regarding https://github.com/voxpupuli/puppet-elasticsearch/pull/1146#issuecomment-1466577899
  • v

    VoxBot

    03/14/2023, 7:50 AM
    But maybe any other can help
  • v

    VoxBot

    03/14/2023, 9:41 AM
    Maybe someone can tell me how to get offending (undoccumented files) from puppet strings
  • v

    VoxBot

    03/14/2023, 9:41 AM
    Maybe someone can tell me how to get offending (undocumented files) from puppet strings
  • a

    Alex Fisher

    03/14/2023, 10:11 AM
    ewoud: Are you able to make the Vox monthly catchup later? Can we add how to deal with legacy facts to the agenda?
1...354355356...648Latest