https://www.puppet.com/community logo
Join Slack
Powered by
# voxpupuli
  • b

    bastelfreak

    02/28/2023, 10:09 AM
    I think in a recent facterdb release we replaced the generated RHEL facts with real ones
    excellent 1
  • b

    bastelfreak

    02/28/2023, 10:09 AM
    but yes, I would love it if the facter people could automatically provide fixtures
  • b

    bastelfreak

    02/28/2023, 10:10 AM
    https://github.com/voxpupuli/facterdb/pull/257
  • b

    bastelfreak

    02/28/2023, 10:10 AM
    https://github.com/voxpupuli/facterdb/pull/257
  • d

    David Sandilands

    02/28/2023, 10:11 AM
    The other thing was they had an interest in minor versions so that when they put in different versions of say 7.x RedHat into metadata it would take the information from facterdb done in
    on_supported_os.each do |os, os_facts|
    and iterate for each minor version too. My hypothetical would be it could essentially override the minor set facts from Pupeptdb. https://github.com/voxpupuli/rspec-puppet-facts/blob/1418bca958049060a77dd49f10a9a298d15dc438/lib/rspec-puppet-facts.rb#L150-L163 What are general thoughts about that?
  • d

    David Sandilands

    02/28/2023, 10:11 AM
    The other thing was they had an interest in minor versions so that when they put in different versions of say 7.x RedHat into metadata it would take the information from facterdb done in
    on_supported_os.each do |os, os_facts|
    and iterate for each minor version too. My hypothetical would be it could essentially override the minor set facts from Pupeptdb. https://github.com/voxpupuli/rspec-puppet-facts/blob/1418bca958049060a77dd49f10a9a298d15dc438/lib/rspec-puppet-facts.rb#L150-L163 What are general thoughts about that?
  • s

    Slackbot

    02/28/2023, 10:11 AM
    This message was deleted.
    d
    b
    • 3
    • 7
  • b

    bastelfreak

    02/28/2023, 10:13 AM
    the whole logic in facterdb and the filesystem layout are based on the assumption that we only have major versions. if support for major+minor versions can be implemented without a breaking change, I'm not opposed.
  • b

    bastelfreak

    02/28/2023, 10:16 AM
    maybe start with a test for metadata-json-lint and see how/if minor versions are supported and checked
    👍 1
  • s

    Slackbot

    02/28/2023, 12:33 PM
    This message was deleted.
    c
    b
    +3
    • 6
    • 87
  • b

    bastelfreak

    02/28/2023, 12:33 PM
    @Alex Fisher @David Sandilands @Craig Gumbley https://github.com/voxpupuli/puppet-lint-topscope-variable-check/pull/22 if you've some spare minutes I would like to have your opinion in that PR
  • b

    bastelfreak

    02/28/2023, 12:49 PM
    https://github.com/puppetlabs/puppet-lint/blob/main/spec/unit/puppet-lint/plugins/legacy_facts/legacy_facts_spec.rb#L169 there are a few tests for topscope facts but not for the facts hash
  • c

    Craig Gumbley

    02/28/2023, 1:24 PM
    https://github.com/puppetlabs/puppet-lint/pull/96
  • c

    Craig Gumbley

    02/28/2023, 1:24 PM
    https://github.com/puppetlabs/puppet-lint/pull/96
  • b

    bastelfreak

    02/28/2023, 1:26 PM
    maybe also add one here: https://github.com/puppetlabs/puppet-lint/blob/05aa8f6bc95cd1794d32575a3548cfbd1fa6c4e6/spec/unit/puppet-lint/plugins/legacy_facts/legacy_facts_spec.rb#L135 to check autofix works properly?
  • r

    Robert Waffen

    02/28/2023, 1:48 PM
    may you pls highlight me if/when you do the voxpupuli-puppet-lint-plugins 4.0 release? i got another PR which needs a update then
  • r

    Robert Waffen

    02/28/2023, 1:48 PM
    or can i somehow subscribe to something? to get notified or link my pr against?
  • r

    Robert Waffen

    02/28/2023, 1:48 PM
    or can i somehow subscribe to something? to get notified or link my pr against?
  • v

    VoxBot

    02/28/2023, 1:56 PM
    typo of the day: fucter…
  • b

    bastelfreak

    02/28/2023, 2:00 PM
    @Robert Waffen https://github.com/voxpupuli/voxpupuli-puppet-lint-plugins/pull/37
    👍 1
  • b

    bastelfreak

    02/28/2023, 2:00 PM
    @Robert Waffen https://github.com/voxpupuli/voxpupuli-puppet-lint-plugins/pull/37
  • r

    Robert Waffen

    02/28/2023, 2:02 PM
    thx
  • s

    Slackbot

    02/28/2023, 2:27 PM
    This message was deleted.
    c
    • 2
    • 4
  • c

    Craig Gumbley

    02/28/2023, 3:00 PM
    @bastelfreak https://github.com/puppetlabs/pdk-templates/pull/498
  • v

    VoxBot

    02/28/2023, 3:24 PM
    can I get a review for https://github.com/voxpupuli/voxpupuli-test/pull/89
  • s

    Slackbot

    02/28/2023, 3:50 PM
    This message was deleted.
    c
    d
    +6
    • 9
    • 27
  • b

    binford2k

    02/28/2023, 3:55 PM
    So who's thought about PMC participation? You've still got a bit of time left to submit a nomination. https://dev.to/puppet/vox-pupuli-pmc-elections-2023-3e99
  • j

    jhoblitt

    02/28/2023, 4:21 PM
    https://github.com/lsst-it/puppet-nm
  • s

    Slackbot

    02/28/2023, 4:54 PM
    This message was deleted.
    j
    p
    • 3
    • 4
  • v

    VoxBot

    02/28/2023, 4:54 PM
    would give a more sane way to do a provider
1...332333334...648Latest