Has someone from Voxpupuli the rights and time to do a review of https://github.com/puppetlabs/puppetlabs-postgresql/pull/1404 Thank you ❤️

Has someone from Voxpupuli the rights and time to do a review of https://github.com/puppetlabs/puppetlabs-postgresql/pull/1404 Thank you ❤️

@cruelsmith can you add a unit test for this?

@bastelfreak Two questions: 1. Is extending https://github.com/puppetlabs/puppetlabs-postgresql/blob/main/spec/classes/server_spec.rb#L204-L215 the right place? (Like adding one with Sensitive password) 2. How can i set a value als Sensitive in rspec?

@bastelfreak Two questions: 1. Is extending https://github.com/puppetlabs/puppetlabs-postgresql/blob/main/spec/classes/server_spec.rb#L204-L215 the right place? (Like adding one with Sensitive password) 2. How can i set a value als Sensitive in rspec?

Oh there is already a rspec test for it: https://github.com/puppetlabs/puppetlabs-postgresql/blob/main/spec/defines/server/role_spec.rb#L40-L62

Oh there is already a rspec test for it: https://github.com/puppetlabs/puppetlabs-postgresql/blob/main/spec/defines/server/role_spec.rb#L40-L62

@cruelsmith

defines/server/role_spec.rb

sounds good

Out of knowledge here for a better way to verify if the password will be set in the right way. Currently we test for

contain_postgresql_psql

that will only see

Sensitive [value redacted]

anyway🤷

@cruelsmith

.with(something: sensitive('value'))

(just saw your PR, the test suite is a mess)

When the value does not match, the generated text is a PITA :

expected that the catalogue would contain Postgresql_psql[ALTER ROLE test ENCRYPTED PASSWORD **] with command set to Sensitive(/ALTER ROLE "test" ENCRYPTED PASSWORD 'n/) but it is set to #<Sensitive [value redacted]>

Hi, i would like to migrate a module to voxpopuli. Who is the right person to talk with?

o/

which module?

one for managing varnish

Is that currently on the forge? Do you want to keep maintaining it?

Started migration to the module

can I get a review on https://github.com/voxpupuli/voxpupuli.github.io/pull/278 ?

+1

https://github.com/voxpupuli/voxpupuli.github.io/pull/279 got another one

voxel: nice. please add the module to our modulesync config: https://github.com/voxpupuli/modulesync_config/blob/master/managed_modules.yml (that's the thing that applies templates to all of our modules)

voxel: can you sign your commit with a gpg key? that's a requirement we have for the modulesync_config an plumbing repo (I recommend signing all commits, but that's not required)

I'll add a gpg config on my side

\o/

nice

fixed now it is signed

not 100% sure if I did that correct.. I'm now stuck at "Execute modulesync for this module."

will join tomorrow again ... it's getting late ;)

o/

voxel: take a look at https://github.com/voxpupuli/modulesync_config#modulesync-configs